Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LanguageServerLauncherTemplate waits 5 seconds even if unneccesary #6091

Closed
tsmaeder opened this issue Aug 24, 2017 · 0 comments
Closed

LanguageServerLauncherTemplate waits 5 seconds even if unneccesary #6091

tsmaeder opened this issue Aug 24, 2017 · 0 comments
Assignees
@tsmaeder
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current

Comments

@tsmaeder
Copy link
Contributor

In the implementation of LanguageServerLauncherTemplate#waitCheckProcess, there is a fixed 5 second wait. This wait should be extended (it's not always enought for jdt.ls, for example) and early return implemented when the process is ready.
I have implemented the fix in a branch and will cherry pick to a PR when convenient.
@tsmaeder tsmaeder self-assigned this Aug 24, 2017
@tsmaeder tsmaeder added kind/enhancement A feature request - must adhere to the feature request template. sprint/current team/osio labels Aug 24, 2017
This was referenced Aug 28, 2017
Closed
Merged
@tsmaeder tsmaeder added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Sep 1, 2017
@tsmaeder tsmaeder closed this as completed Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmaeder tsmaeder

Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tsmaeder