Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON-RPC over Websockets back-end in Project API #6122

Closed
vparfonov opened this issue Sep 4, 2017 · 2 comments
Closed

Add JSON-RPC over Websockets back-end in Project API #6122

vparfonov opened this issue Sep 4, 2017 · 2 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current status/in-progress This issue has been taken by an engineer and is under active development.

Comments

@vparfonov
Copy link
Contributor

vparfonov commented Sep 4, 2017

For now our client (IDE) communicate with Project Service via REST in same time we receive notification from File Watching System via JSON-RPC over Websockets. This situation complicate our model and hard for documentation, so we decide to switch client communication to the JSON-RPC calls.

Under this issue need to:

  • add JSON-RPC handlers/transmitters on server-side;
  • deprecate ProjectServiceClient in IDE client API;
  • replace ProjectServiceClient with JSON-RPC calls
  • remove deprecated classes
@dkuleshov dkuleshov self-assigned this Sep 4, 2017
@dkuleshov dkuleshov added the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 4, 2017
@gazarenkov
Copy link
Contributor

@dkuleshov could you please draft a short specs (right here) about how we replace REST with JSON-RPC for Project API, it is really interesting and important exercise since there are a lot of different methods.

@vparfonov vparfonov added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels Sep 5, 2017
@dkuleshov
Copy link

@gazarenkov here is a spec draft #6219

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

3 participants