Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added JSON-RPC back-end to Project API and removed deprecated VFS classes #6603

Closed
wants to merge 6 commits into from
Closed

Added JSON-RPC back-end to Project API and removed deprecated VFS classes #6603

wants to merge 6 commits into from

Conversation

dkuleshov
Copy link

@dkuleshov dkuleshov commented Oct 5, 2017 •
edited
Loading

Work is still in progress.
Original issue: #6122

Changes to Project Service:

Changes to Project Manager:

  • Refactoring and decomposition
  • Reworked package structure
  • Split Guice configuration into several classes
  • Reworked architecture (where it is possible) to comply DI pattern

Changes to VFS

  • Removed all deprecated VFS related classes
  • Rearranged code accordingly
  • Provided new FS API where needed

Changes to Search

  • Reworked index classes that depend on VFS

What is yet to be done:

  • Pass selenium tests
  • Rework/add unit tests
  • Rework/add java docs

@dkuleshov dkuleshov added the status/in-progress This issue has been taken by an engineer and is under active development. label Oct 5, 2017
@dkuleshov dkuleshov self-assigned this Oct 5, 2017
Dmytro Kulieshov added 6 commits October 5, 2017 19:05
initial commit
b04908f 
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
fixes and refactoring
2004b71 
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
fixed bugs, rearranged packages, moved guice conf to separate module …
2f56746 
…classes

Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
more refactoring
667f173 
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
bug fixes for project importing
63fc8c0 
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
fix for selenium tests
0d78a83 
Signed-off-by: Dmytro Kulieshov <dkuliesh@redhat.com>
@dkuleshov
Copy link
Author

ci-test

@benoitf benoitf added the target/branch Indicates that a PR will be merged into a branch other than master. label Oct 5, 2017
@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@codenvy-ci
Copy link

Build # 4024 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4024/ to view the results.

@benoitf benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Oct 12, 2017
@dkuleshov dkuleshov changed the base branch from spi to che6 October 13, 2017 11:02
@skabashnyuk skabashnyuk mentioned this pull request Oct 15, 2017
Merged
@skabashnyuk skabashnyuk added this to the 6.0.0-M1 milestone Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evidolob evidolob Awaiting requested review from evidolob

@skabashnyuk skabashnyuk Awaiting requested review from skabashnyuk

@tolusha tolusha Awaiting requested review from tolusha

@vparfonov vparfonov Awaiting requested review from vparfonov

Assignees

@dkuleshov dkuleshov

Labels
kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Milestone
6.0.0-M1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dkuleshov @codenvy-ci @benoitf @skabashnyuk