Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI build success if CLI tests are failing #6134

Closed
riuvshin opened this issue Sep 5, 2017 · 1 comment
Closed

CI build success if CLI tests are failing #6134

riuvshin opened this issue Sep 5, 2017 · 1 comment
Assignees
@riuvshin
Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current

Comments

@riuvshin
Copy link
Contributor

riuvshin commented Sep 5, 2017

we have some failed CLI tests but CI job that check tests is green because tests finished with 0 exit code.
actions:

  • make tests fail job
  • fix tests
@riuvshin riuvshin added kind/bug Outline of a bug - must adhere to the bug report template. sprint/current status/in-progress This issue has been taken by an engineer and is under active development. team/production labels Sep 5, 2017
@riuvshin riuvshin self-assigned this Sep 5, 2017
This was referenced Sep 5, 2017
Merged
Merged
@riuvshin
Copy link
Contributor Author

riuvshin commented Sep 5, 2017

done

@riuvshin riuvshin closed this as completed Sep 5, 2017
@riuvshin riuvshin removed the status/in-progress This issue has been taken by an engineer and is under active development. label Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@riuvshin riuvshin

Labels
kind/bug Outline of a bug - must adhere to the bug report template. sprint/current
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riuvshin