Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE tomcat should not fail if KC is not accessible on starting #9235

Closed
riuvshin opened this issue Mar 26, 2018 · 3 comments
Closed

CHE tomcat should not fail if KC is not accessible on starting #9235

riuvshin opened this issue Mar 26, 2018 · 3 comments
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@riuvshin
Copy link
Contributor

with changes introduced by this PR #8650
we have a regression that CHE server may completely fail during start-up if it will fail to connect to KC.
we added few workarounds which managed the right sequence of launching services but it will not cover a use case for instance with OSIO when we will need to restart CHE server and due to some reason it will not be able to connect to KC server on startup due to network issues or some other things.
I see two potential ways of solving that:

  • refactor code and add an ability to retry to connect to the KC
  • move everything that CHE is retrieving from KC to the configuration, and configure it before CHE start.

I prefer the first one because less to configure - easier to deploy / maintain

@riuvshin riuvshin added the kind/bug Outline of a bug - must adhere to the bug report template. label Mar 26, 2018
@skabashnyuk
Copy link
Contributor

is this issue up to date?

@riuvshin
Copy link
Contributor Author

yes, I think the problem is still there.

@skabashnyuk skabashnyuk added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Sep 17, 2018
@mkuznyetsov mkuznyetsov self-assigned this Oct 26, 2018
@che-bot
Copy link
Contributor

che-bot commented Sep 7, 2019

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 7, 2019
@che-bot che-bot closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants