Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parametrize keycloak admin user in templates #9489

Closed
siamaksade opened this issue Apr 18, 2018 · 4 comments
Closed

Parametrize keycloak admin user in templates #9489

siamaksade opened this issue Apr 18, 2018 · 4 comments
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.

Comments

@siamaksade
Copy link

The KeyCloak admin user and password is hard-coded to admin in the templates:
https://github.com/eclipse/che/tree/master/deploy/openshift/templates

They should become template parameters.

@ghost
Copy link

ghost commented Apr 19, 2018

@siamaksade they are hardcoded but in jsons here - https://github.com/eclipse/che/tree/master/dockerfiles/init/modules/keycloak/templates

Env variables are ignored in this case. I'll issue a PR to fix it. Thanks for the pointer.

@ghost ghost added the kind/question Questions that haven't been identified as being feature requests or bugs. label Apr 19, 2018
@siamaksade
Copy link
Author

Slight relevant to this, the CHE_KEYCLOAK_ADMIN_REQUIRE_UPDATE_PASSWORD template param should only be in the keycloak template. It's not used in Che template

@ghost
Copy link

ghost commented Apr 20, 2018

@siamaksade it is not use din Che template. Not sure I understand your comment.

@ghost
Copy link

ghost commented Apr 24, 2018

Closing this issue as the original request was addressed in a merged PR. @siamaksade feel free to open a separate issue related to your another concern.

@ghost ghost closed this as completed Apr 24, 2018
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Questions that haven't been identified as being feature requests or bugs.
Projects
None yet
Development

No branches or pull requests

1 participant