CHE-10590: Create image to build machine exec for terminal-extension and for task api extension. #10812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
benoitf
added
status/code-review
mmorhun
approved these changes
Aug 17, 2018
|
nice, few suggestions for README file:
|
olexii4
reviewed
Aug 17, 2018
| ENV MACHINE_EXEC_HASH b57b40eb2088271dc24f538f224f8c1ac474a777 | ||
| ENV MACHINE_EXEC github.com/eclipse/che-theia-terminal-plugin/machine-exec-server | ||
|
|
||
| RUN yum -y update && yum install -y git && git --version && \ |
There was a problem hiding this comment.
" git --version "
Do we really need it?
There was a problem hiding this comment.
Nice catch, I will fix it.
olexii4
approved these changes
Aug 17, 2018
|
Current pull request will be moved to the another repo (it will called che-machine-exec) #10817 |
|
Close pull request on favor eclipse-che/che-machine-exec#1 . Repository https://github.com/eclipse/che-machine-exec contains own CI to build docker image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create image to build machine exec for terminal-extension and for task api extension.
What issues does this PR fix or reference?
#10590