-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it possible to update and stop a workspace #13181
Conversation
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
ci-build |
I have doubts about |
@mshaposhnik Can you elaborate more about your doubts? |
@mshaposhnik To add a Theia plugin we need to update "plugins" attribute of workspace configuration. |
@sleshchenko I have an issue with CLA. Let me update it later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please test it before merging.
Ok i see that in fact only config is updated in manager (i was thinking about possibility to update owner etc) |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1728//Selenium_20tests_20report/) doesn't show any regression against this Pull Request. |
@SkorikSergey Thanks! |
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Enables updating and stopping a workspace for multi-user instances for requests with machine token.
Is needed for plugin installation flow #12905
What issues does this PR fix or reference?
Part of the issue #12905