Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to update and stop a workspace #13181

Merged
merged 1 commit into from
Apr 19, 2019

Conversation

vitaliy-guliy
Copy link
Contributor

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What does this PR do?

Enables updating and stopping a workspace for multi-user instances for requests with machine token.
Is needed for plugin installation flow #12905

What issues does this PR fix or reference?

Part of the issue #12905

Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
@vitaliy-guliy
Copy link
Contributor Author

ci-build

@sleshchenko
Copy link
Member

sleshchenko commented Apr 18, 2019

Did you sign ECA?
Screenshot_20190418_104211

@mshaposhnik
Copy link
Contributor

I have doubts about update. Can't we avoid it somehow ?

@sleshchenko
Copy link
Member

I have doubts about update. Can't we avoid it somehow ?

@mshaposhnik Can you elaborate more about your doubts?
I see no issue in having an ability to update the current workspace with machine token.

@vitaliy-guliy
Copy link
Contributor Author

vitaliy-guliy commented Apr 18, 2019

@mshaposhnik To add a Theia plugin we need to update "plugins" attribute of workspace configuration.

@vitaliy-guliy
Copy link
Contributor Author

@sleshchenko I have an issue with CLA. Let me update it later.

Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please test it before merging.

@mshaposhnik
Copy link
Contributor

mshaposhnik commented Apr 18, 2019

@mshaposhnik Can you elaborate more about your doubts?

Ok i see that in fact only config is updated in manager (i was thinking about possibility to update owner etc)

@vitaliy-guliy
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Apr 18, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13181
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@SkorikSergey
Copy link
Contributor

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1728//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@vitaliy-guliy
Copy link
Contributor Author

@SkorikSergey Thanks!

@vitaliy-guliy vitaliy-guliy merged commit dcf1486 into master Apr 19, 2019
@vitaliy-guliy vitaliy-guliy deleted the workspace-actions branch April 19, 2019 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants