Remove dummy workspace config if devfile is present #13403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergii Leshchenko <sleshche@redhat.com>
sleshchenko
added
the
kind/task
|
ci-test |
|
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
|
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1812//Selenium_20tests_20report/) doesn't show any regression against this Pull Request. |
mshaposhnik
reviewed
May 23, 2019
| // devfile is not null and config should be dropped since it's a stub with name only | ||
| update.setConfig(null); | ||
| } | ||
| update.getConfig() != null ^ update.getDevfile() != null, |
There was a problem hiding this comment.
Found in SOF:
Logical exclusive-or in Java is called !=. You can also use ^ if you want to confuse your friends.
mshaposhnik
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Since PR with the adaptation of UD is merged, dummy workspace config must be removed
What issues does this PR fix or reference?
Release Notes
N/A
Docs PR
N/A