Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove methods from /api/devfile that allow creating a workspace #13992

Merged
merged 8 commits into from
Jul 30, 2019
Merged

Remove methods from /api/devfile that allow creating a workspace #13992

merged 8 commits into from
Jul 30, 2019

Conversation

skabashnyuk
Copy link
Contributor

What does this PR do?

Remove methods from /api/devfile that allow creating a workspace

What issues does this PR fix or reference?

Fixes #13867

Release Notes

n/a

Docs PR

n/a

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 24, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13992
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@nickboldt
Copy link
Contributor

Looks like this broke a lot of tests, which may need to be updated/removed too. :(

@skabashnyuk skabashnyuk changed the title Remove methods from /api/devfile that allow creating a workspace [WIP] Remove methods from /api/devfile that allow creating a workspace Jul 25, 2019
@skabashnyuk skabashnyuk changed the title [WIP] Remove methods from /api/devfile that allow creating a workspace Remove methods from /api/devfile that allow creating a workspace Jul 25, 2019
@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 25, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13992
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 25, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13992
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor Author

@eclipse/eclipse-che-qa can you comment on test results. Are they acceptable?

sleshchenko
sleshchenko reviewed Jul 26, 2019
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to remove outdated and used DevfileManager#exportWorkspace, DevfileManager#createWorkspace, DevfileManager#createWorkspaceConfig methods? Or it's supposed in be done in scope of another issue?

...api-workspace/src/main/java/org/eclipse/che/api/workspace/server/devfile/DevfileService.java Outdated Show resolved Hide resolved
@SkorikSergey
Copy link
Contributor

@eclipse/eclipse-che-qa can you comment on test results. Are they acceptable?

Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/1951//Selenium_20tests_20report/) doesn't show any regression against this Pull Request.

@skabashnyuk
fixup! Merge remote-tracking branch 'origin/master' into che13867_2
ec63421 
Signed-off-by: Sergii Kabashniuk <skabashniuk@redhat.com>
@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 26, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13992
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor Author

ci-test

@che-bot
Copy link
Contributor

che-bot commented Jul 30, 2019

Results of automated E2E tests of Eclipse Che Multiuser on OCP:
Build details
Test report
docker image: eclipseche/che-server:13992
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@skabashnyuk
Copy link
Contributor Author

Are you going to remove outdated and used DevfileManager#exportWorkspace, DevfileManager#createWorkspace, DevfileManager#createWorkspaceConfig methods?

@sleshchenko these methods have been removed.

sleshchenko
sleshchenko approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skabashnyuk skabashnyuk merged commit 1281a58 into master Jul 30, 2019
@skabashnyuk skabashnyuk deleted the che13867_2 branch July 30, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshaposhnik mshaposhnik mshaposhnik approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

@l0rd l0rd Awaiting requested review from l0rd

@metlos metlos Awaiting requested review from metlos

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate and remove /api/devfile method
6 participants
@skabashnyuk @che-bot @nickboldt @SkorikSergey @mshaposhnik @sleshchenko