Various improvements of Jenkins pipeline to run Che E2E Happy path tests on PR check #15064

dmytro-ndp · 2019-11-01T17:40:09Z

What does this PR do?

Build upstream projects che-parent, che-docs.
Build on upstream slave instead of cloud-slave9.
Apply workaround to start K8S issue Start of minikube fails on CRW CI instance #14902.
Start and test Multiuser Che assembly.
Add next parameters to make it possible to reuse pipeline in nightly and pre-release testing jobs:

cheImageRepo - Repo of Che server image
cheImageTag - Tag of Che server image
buildChe - to turn off building of Che
e2eTestToRun - test suite to be run
createTestWorkspace - to turn off creation of test workspace

What issues does this PR fix or reference?

#14902, #14941, #13473, #15284, #15291

che-bot · 2019-11-01T17:40:28Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T17:42:18Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T17:47:22Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T17:53:45Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T18:43:32Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15064
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-11-01T19:24:51Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T20:10:04Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T20:16:32Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T20:55:01Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T21:40:47Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T22:07:00Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T22:21:44Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T23:06:01Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-01T23:42:00Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15064
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

che-bot · 2019-11-02T10:31:34Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-02T10:43:21Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-02T11:03:50Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-02T11:08:31Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-02T11:47:20Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-02T12:07:39Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

che-bot · 2019-11-02T12:31:30Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

dmytro-ndp · 2019-11-24T08:12:09Z

crw-ci-test

che-bot · 2019-11-24T08:59:20Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:15064

che-bot · 2019-11-24T09:07:24Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-11-24T10:04:08Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:15064

che-bot · 2019-11-24T10:24:10Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

dmytro-ndp · 2019-11-24T12:57:43Z

crw-ci-test

dmytro-ndp · 2019-11-24T12:57:51Z

crw-ci-test

che-bot · 2019-11-24T13:34:14Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-24T14:15:33Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-11-24T20:19:06Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-24T20:21:57Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

Build details
Test report
docker image: eclipseche/che-server:15064

dmytro-ndp · 2019-11-24T20:31:50Z

crw-ci-test

dmytro-ndp · 2019-11-24T22:04:03Z

crw-ci-test

che-bot · 2019-11-24T22:32:53Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Katka92

I'm not familiar with all the configuration, but from an overall look, it seems good to me. I've added just a few minor questions.

Katka92 · 2019-11-25T06:44:50Z

e2e/jenkins/crw-ci/pr-check/k8s/Jenkinsfile

+                defaultValue: "test-happy-path",
+                description: 'TypeScript E2E test to run')
+
+        string(name: 'testWorkspaceDevfileUrl',


Why there are two devfiles which seem pretty the same? Are both DEVFILE_PATH and testWorkspaceDevfileUrl needed?

Good catch!

Katka92 · 2019-11-25T06:54:25Z

e2e/jenkins/crw-ci/pr-check/k8s/Jenkinsfile

+                    USER_ACCESS_TOKEN=\$(curl -X POST \$KEYCLOAK_BASE_URL/realms/che/protocol/openid-connect/token \\
+                       -H "Content-Type: application/x-www-form-urlencoded" \\
+                       -d "username=admin" \\
+                       -d "password=admin" \\


Is it safe to have credentials here?

It's default admin credentials for Eclipse Che.

Katka92 · 2019-11-25T07:00:20Z

e2e/jenkins/crw-ci/pr-check/k8s/Jenkinsfile


-                archiveArtifacts allowEmptyArchive: true, artifacts: "e2e/report/**, logs-and-configs/**"
+                cp ${WORKSPACE}/org_v1_che_cr.yaml $LOGS_AND_CONFIGS/che-config || true


Wouldn't it be better to add set +e and set -e for a block of commands than adding || true after each command?

Yes, it would be better, by I don't now how to do it in pipeline so that it works for ALL sh commands.

I see, I'm not much familiar with pipelines, but maybe using this set in each script when more commands are running with || true will help too. But I'm OK event with having it as it is. :)

Katka92 · 2019-11-25T07:01:17Z

e2e/jenkins/crw-ci/pr-check/k8s/Jenkinsfile

+                sh """
+                     docker pull eclipse/che-e2e:nightly
+
+                     CHE_HOST=\$(kubectl get ingress che -n=che -o=jsonpath={'.spec.rules[0].host'})


CHE_HOST is obtained already on line 169. Can it be reused?

It's a good point. Thanks.

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

che-bot · 2019-11-25T10:01:18Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2019-11-25T10:29:48Z

E2E tests of Eclipse Che Multiuser on OCP has failed:

Build details
Test report
docker image: eclipseche/che-server:15064
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.
Use command "ci-test" to rerun the test.

dmytro-ndp · 2019-11-25T10:42:05Z

crw-ci-test

che-bot · 2019-11-25T10:56:38Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

dmytro-ndp · 2019-11-25T11:07:42Z

crw-ci-test

che-bot · 2019-11-25T11:33:52Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:15064

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

⚠️ https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

rhopp · 2019-11-25T12:14:58Z

e2e/jenkins/crw-ci/pr-check/k8s/Jenkinsfile

-                               sudo chmod +x ${WORKSPACE}/chectl
-                            """
-                        }
+                        // TO-DO use option "--install-path" https://github.com/eclipse/che/pull/14182


We already have a solution for downloading just chectl binary (without the whole installation script & isntalling into global locations).
This note is not blocking PR merging (mostly because we are using one use slaves)

dmytro-ndp requested review from l0rd, musienko-maxim, nickboldt, Ohrimenko1988 and rhopp as code owners November 1, 2019 17:40

che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Nov 1, 2019

dmytro-ndp changed the title ~~Various improvements of Jenkins pipeline to rub Che E2E Happy path tests on PR check~~ Various improvements of Jenkins pipeline to run Che E2E Happy path tests on PR check Nov 1, 2019

dmytro-ndp force-pushed the che-14941 branch from 9bd756a to edfd239 Compare November 2, 2019 11:06

Fix error

96d3d46

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Restore testWorkspaceDevfileUrl

86ef83c

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

eclipse-che deleted a comment from che-bot Nov 24, 2019

Katka92 approved these changes Nov 25, 2019

View reviewed changes

dmytro-ndp added 2 commits November 25, 2019 11:19

Remove redundant DEVFILE_PATH variable

b1947f1

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

Calculate cheHost ones

f907b09

Signed-off-by: Dmytro Nochevnov <dnochevn@redhat.com>

rhopp approved these changes Nov 25, 2019

View reviewed changes

dmytro-ndp merged commit 5e5e30f into master Nov 25, 2019

dmytro-ndp deleted the che-14941 branch November 25, 2019 12:54

dmytro-ndp mentioned this pull request Nov 25, 2019

Fix test workspace devfile address for PR based on fork #15311

Merged


		archiveArtifacts allowEmptyArchive: true, artifacts: "e2e/report/, logs-and-configs/"
		cp ${WORKSPACE}/org_v1_che_cr.yaml $LOGS_AND_CONFIGS/che-config \|\| true

Various improvements of Jenkins pipeline to run Che E2E Happy path tests on PR check #15064

Various improvements of Jenkins pipeline to run Che E2E Happy path tests on PR check #15064

Conversation

dmytro-ndp commented Nov 1, 2019 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 1, 2019

che-bot commented Nov 2, 2019

che-bot commented Nov 2, 2019

che-bot commented Nov 2, 2019

che-bot commented Nov 2, 2019

che-bot commented Nov 2, 2019

che-bot commented Nov 2, 2019

che-bot commented Nov 2, 2019

dmytro-ndp commented Nov 24, 2019

che-bot commented Nov 24, 2019

che-bot commented Nov 24, 2019

che-bot commented Nov 24, 2019

che-bot commented Nov 24, 2019

dmytro-ndp commented Nov 24, 2019

dmytro-ndp commented Nov 24, 2019

che-bot commented Nov 24, 2019

che-bot commented Nov 24, 2019

che-bot commented Nov 24, 2019

che-bot commented Nov 24, 2019

dmytro-ndp commented Nov 24, 2019

dmytro-ndp commented Nov 24, 2019

che-bot commented Nov 24, 2019

Katka92 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

che-bot commented Nov 25, 2019

che-bot commented Nov 25, 2019

dmytro-ndp commented Nov 25, 2019

che-bot commented Nov 25, 2019

dmytro-ndp commented Nov 25, 2019

che-bot commented Nov 25, 2019

Choose a reason for hiding this comment

dmytro-ndp commented Nov 1, 2019 •

edited

Loading