Use dashboard to restart the workspace #15180
Conversation
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
vitaliy-guliy
requested review from
evidolob,
sleshchenko,
AndrienkoAleksandr and
akurinnoy
vitaliy-guliy
requested review from
ashumilova,
benoitf,
l0rd,
nickboldt and
rhopp
as code owners
che-bot
added
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
| }, (error: any) => { | ||
| if (error && error.status === 304) { | ||
| defer.resolve(); | ||
| return; |
There was a problem hiding this comment.
Should we return return defer.promise;?
There was a problem hiding this comment.
No, we only need there to resolve or reject that deferred object promise. And return it at the end of the method.
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
|
@vitaliy-guliy you need to cherry-pick this PR to |
|
Corresponding PR to 7.3.x #15194 |
|
ci-test |
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
* Use dashboard to restart the workspace Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com> * Use authorization header instead of query parameter Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com
What does this PR do?
Adds an event handler to the Dashboard to restart the workspace by the request from the IDE opened in the frame.
What issues does this PR fix or reference?
#15006
Connected with eclipse-che/che-theia#541