add websocket stream check before sending a message #15369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksii Orel <oorel@redhat.com>
olexii4
requested review from
benoitf,
evidolob,
ashumilova,
AndrienkoAleksandr and
akurinnoy
che-bot
added
kind/enhancement
skabashnyuk
reviewed
Nov 30, 2019
benoitf
approved these changes
Nov 30, 2019
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
AndrienkoAleksandr
approved these changes
Nov 30, 2019
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
che-bot
removed
the
status/code-review
olexii4
added a commit
that referenced
this pull request
Dec 2, 2019
* Add WebSocket stream check before sending a message Signed-off-by: Oleksii Orel <oorel@redhat.com>
olexii4
added a commit
that referenced
this pull request
Dec 2, 2019
* Add WebSocket stream check before sending a message Signed-off-by: Oleksii Orel <oorel@redhat.com>
skabashnyuk
pushed a commit
that referenced
this pull request
Jan 3, 2020
* Add WebSocket stream check before sending a message Signed-off-by: Oleksii Orel <oorel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Add WebSocket stream check before sending a message to predict an error "Cannot read property 'send' of undefined".
What issues does this PR fix or reference?
https://issues.jboss.org/browse/CRW-533
Release Notes
Docs PR