Add ability to set up Che workspace and postgress pvc class names using helm. #15677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
AndrienkoAleksandr
requested review from
ibuziuk,
l0rd,
nickboldt,
rhopp and
sleshchenko
as code owners
sleshchenko
reviewed
Jan 13, 2020
| @@ -62,6 +62,8 @@ global: | |||
| # Possible values: common, per-workspace, unique | |||
| cheWorkspacesPVCStrategy: "common" | |||
| pvcClaim: "1Gi" | |||
| cheWorkspacePVCStorageClassName: "" | |||
| chePostgresPVCStorageClassName: "" | |||
There was a problem hiding this comment.
Let put it somewhere in postgres related section?
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
|
E2E tests of Eclipse Che Multiuser on OCP has failed:
|
che-bot
added
status/code-review
…pChePVCClassNamesUsingHelm
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
|
Can one of the admins verify this patch? |
musienko-maxim
approved these changes
Jan 16, 2020
|
E2E tests of Eclipse Che Multiuser on OCP has been successful:
|
AndrienkoAleksandr
deleted the
addAbilityToSetUpChePVCClassNamesUsingHelm
branch
che-bot
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ability to set up Che workspace and Postgres pvc class names using helm.
What issues does this PR fix or reference?
#15157
Signed-off-by: Oleksandr Andriienko oandriie@redhat.com