Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix owners of stages; explain stage... #16037

Merged

Conversation

nickboldt
Copy link
Contributor

fix owners of stages; explain stage ordering; add milestone cleanup steps; add intra-step dependencies

Change-Id: If69a518b6dd2d30742b47e83462bd5b24b81bbdd
Signed-off-by: nickboldt nboldt@redhat.com

@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

Can one of the admins verify this patch?

3 similar comments
@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

Can one of the admins verify this patch?

@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

Can one of the admins verify this patch?

@che-bot che-bot added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 13, 2020
@nickboldt nickboldt added area/ci CI build and releases, PR testing, & whitelabel/productization issues area/productization and removed kind/bug Outline of a bug - must adhere to the bug report template. labels Feb 13, 2020
@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

@che-bot che-bot added the kind/bug Outline of a bug - must adhere to the bug report template. label Feb 13, 2020
@nickboldt nickboldt mentioned this pull request Feb 14, 2020
19 tasks
…teps; add intra-step dependencies

Change-Id: If69a518b6dd2d30742b47e83462bd5b24b81bbdd
Signed-off-by: nickboldt <nboldt@redhat.com>

add link to che-server image in quay

Change-Id: I4aec2ae1b12c970ff30170bd63c4c0a9c036c496
Signed-off-by: nickboldt <nboldt@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Feb 24, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

| @vparfonov / @mkuznyetsov| [che-parent](https://github.com/eclipse/che/blob/master/RELEASE.md) | [***MANUAL***](https://github.com/eclipse/che/blob/master/RELEASE.md) | [centos](https://ci.centos.org/job/devtools-che-parent-che-release/) | [che-parent](https://search.maven.org/search?q=a:che-parent), [che.depmgt](https://search.maven.org/artifact/org.eclipse.che.depmgt/maven-depmgt-pom) |
| @vparfonov / @mkuznyetsov| [che-docs](https://github.com/eclipse/che/blob/master/RELEASE.md) | [***MANUAL***](https://github.com/eclipse/che/blob/master/RELEASE.md) | [centos](https://ci.centos.org/job/devtools-che-docs-che-release/) | [che-docs](https://search.maven.org/search?q=a:che-docs)
| @vparfonov / @mkuznyetsov| [che](https://github.com/eclipse/che/blob/master/RELEASE.md) | [***MANUAL***](https://github.com/eclipse/che/blob/master/RELEASE.md) | [centos](https://ci.centos.org/job/devtools-che-che-release/) | [che.core](https://search.maven.org/search?q=che.core) |
| @davidfestal| [che-operator](https://github.com/eclipse/che-operator/blob/master/RELEASE.md) | [make-release.sh](https://github.com/eclipse/che-operator/blob/master/make-release.sh) | ? | [`quay.io/eclipse/che-operator`](https://quay.io/eclipse/che-operator)|
| @vparfonov / @mkuznyetsov| [che](https://github.com/eclipse/che/blob/master/RELEASE.md) | [***MANUAL***](https://github.com/eclipse/che/blob/master/RELEASE.md) | [centos](https://ci.centos.org/job/devtools-che-che-release/) | [che.core](https://search.maven.org/search?q=che.core), [`quay.io/eclipse/che-server`](https://quay.io/eclipse/che-server) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove @vparfonov from this section

Copy link
Contributor Author

@nickboldt nickboldt Feb 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're still using your credentials for Nexus... no, not yet. :)

Once Mykhailo can push using his own user id, or a bot, then we can remove you. Until then you're still involved.

@benoitf
Copy link
Contributor

benoitf commented Feb 25, 2020

[ci-build]

@benoitf
Copy link
Contributor

benoitf commented Feb 25, 2020

@nickboldt let's merge ?

@nickboldt nickboldt merged commit 0d51cb4 into eclipse-che:master Mar 3, 2020
@nickboldt
Copy link
Contributor Author

@benoitf if you see a stalled approved PR waiting for me to merge, feel free to just merge it :) Teamwork makes the clean work!

@che-bot che-bot added this to the 7.10.0 milestone Mar 3, 2020
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants