Cherry-pick #16289 to 7.9.x release branch #16290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amisevsk
requested review from
l0rd,
metlos,
rhopp and
sleshchenko
as code owners
che-bot
added
target/branch
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
davidfestal
approved these changes
Mar 9, 2020
sleshchenko
approved these changes
Mar 10, 2020
This commit is a cherry-pick of 78ee3bf from master Fixes an issue where container names for brokers could be longer than 63 characters: - If a broker image is referenced by tag, trim the digest to 10 chars and use that instead of the full thing - If the generated name is longer than 63 chars for whatever reason, trim it to allow the workspace to start. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
amisevsk
force-pushed
the
handle-broker-digests-7.9.x
branch
from
ef7d88b
to
6bef13f
Compare
che-bot
removed
the
status/code-review
|
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) ℹ️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick changes from #16289 into release.