feat: kubernetes keycloak deployment strategy #17304

kesslerdev · 2020-07-01T15:03:59Z

What does this PR do?

Allow to set the deployment strategy, for the keycloak deployment chart
the default strategy RollingUpdate fail if multiattach is not supported by volumes

deploy/kubernetes/helm/che/custom-charts/che-keycloak/values.yaml

sleshchenko · 2020-07-02T05:03:47Z

deploy/kubernetes/helm/che/custom-charts/che-keycloak/values.yaml

@@ -15,3 +15,4 @@ image: quay.io/eclipse/che-keycloak:nightly
 requireAdminPasswordChange: true
 keycloakAdminUserName: admin
 keycloakAdminUserPassword: admin
+deploymentStrategy: RollingUpdate


Allow to set the deployment strategy, the default RollingUpdate fail if multiattach is not supported by volumes

I think in most cases it won't be supported. What about setting default to recreate which mean - introduce an ability to override default but not change the behavior we already have?

but other charts postgres, che, already have Recreate as deploy strategy

che-bot · 2020-07-02T12:00:50Z

Can one of the admins verify this patch?

che-bot · 2020-07-02T12:00:50Z

Can one of the admins verify this patch?

tolusha · 2020-07-15T07:05:16Z

[test]

dmytro-ndp · 2020-07-15T07:09:41Z

[ci-build]

dmytro-ndp · 2020-07-15T07:11:15Z

[crw-ci-test]

che-bot · 2020-07-15T07:18:18Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

dmytro-ndp · 2020-07-15T07:26:59Z

@tolusha: commands to trigger CI jobs:

[ci-build] - ci.centos.org PR check (build)
[ci-test] - ci.centos.org PR check (java-selenium-tests)
[crw-ci-test] - crw-ci-e2e-happy-path-tests

che-bot · 2020-07-15T08:44:05Z

E2E tests of Eclipse Che Multiuser on OCP has been successful:

tolusha · 2020-07-15T11:36:23Z

[crw-ci-test]

che-bot · 2020-07-15T11:42:23Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

tolusha · 2020-07-29T07:07:35Z

[crw-ci-test]

che-bot · 2020-07-29T07:11:38Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

mmorhun · 2020-07-29T08:47:58Z

cc @dmytro-ndp could you please take a look why the tests failed? Looks like not PR related. Thanks.

mmorhun · 2020-08-19T14:31:02Z

[crw-ci-test]

che-bot · 2020-08-19T14:38:04Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

Ohrimenko1988 · 2020-08-20T07:00:03Z

[crw-ci-test]

che-bot · 2020-08-20T07:05:34Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

flacatus · 2020-08-27T08:17:08Z

[crw-ci-test]

che-bot · 2020-08-27T08:22:57Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

dmytro-ndp · 2020-08-27T08:55:10Z

@kesslerdev: PR needs to be updated from master branch, to fix Happy path tests build error:

[Build Che including upstream projects] [ERROR] The build could not read 1 project -> [Help 1]
[Build Che including upstream projects] [ERROR]   
[Build Che including upstream projects] [ERROR]   The project org.eclipse.che.docs:che-docs:7.13.0-SNAPSHOT (/mnt/hudson_workspace/workspace/Multiuser-Che-PR-check-E2E-Happy-path-tests-against-k8s/eclipse/che-docs/pom.xml) has 1 error
[Build Che including upstream projects] [ERROR]     Non-resolvable parent POM for org.eclipse.che.depmgt:maven-depmgt-pom:7.13.0-SNAPSHOT: Could not find artifact org.eclipse.che.parent:maven-parent-pom:pom:7.13.0-SNAPSHOT in ossrh (https://oss.sonatype.org/content/repositories/snapshots/) @ org.eclipse.che.depmgt:maven-depmgt-pom:7.13.0-SNAPSHOT, /home/hudson/.m2/repository/org/eclipse/che/depmgt/maven-depmgt-pom/7.13.0-SNAPSHOT/maven-depmgt-pom-7.13.0-SNAPSHOT.pom, line 17, column 13 -> [Help 2]

mmorhun · 2020-09-16T14:29:17Z

@kesslerdev please rebase your changes. Then we can merge this PR.

Allow to set the deployment strategy, the default RollingUpdate fail if multiattach is not supported by volumes Signed-off-by: Jean-François Monnier <kessler.dev@gmail.com>

Signed-off-by: Jean-François Monnier <kessler.dev@gmail.com> Co-authored-by: Serhii Leshchenko <sleshche@redhat.com>

kesslerdev · 2020-09-21T14:25:08Z

@kesslerdev please rebase your changes. Then we can merge this PR.

Done !

tolusha · 2020-09-22T06:43:05Z

[crw-ci-test]

che-bot · 2020-09-22T07:18:05Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

flacatus · 2020-09-22T07:18:29Z

[crw-ci-test]

che-bot · 2020-09-22T07:51:16Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: maxura/che-server:17304

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

tolusha · 2020-09-23T06:31:46Z

The only failed tests is related java ls which is a known issue.
The PR is ready to merge.

benoitf · 2020-09-23T06:52:03Z

[ci-build]

mmorhun · 2020-09-23T07:29:10Z

@kesslerdev thank you for contribution.

kesslerdev requested review from l0rd, nickboldt and sleshchenko as code owners July 1, 2020 15:03

che-bot added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jul 1, 2020

sleshchenko reviewed Jul 2, 2020

View reviewed changes

sleshchenko requested review from mmorhun and tolusha July 2, 2020 05:04

kesslerdev force-pushed the master branch from d6d428c to c23974f Compare July 2, 2020 12:02

mmorhun approved these changes Jul 15, 2020

View reviewed changes

kesslerdev and others added 2 commits September 21, 2020 16:23

feat: kubernetes keycloak deployment strategy

9004b05

Allow to set the deployment strategy, the default RollingUpdate fail if multiattach is not supported by volumes Signed-off-by: Jean-François Monnier <kessler.dev@gmail.com>

Update deploy/kubernetes/helm/che/custom-charts/che-keycloak/values.yaml

efd7339

Signed-off-by: Jean-François Monnier <kessler.dev@gmail.com> Co-authored-by: Serhii Leshchenko <sleshche@redhat.com>

kesslerdev force-pushed the master branch from c23974f to efd7339 Compare September 21, 2020 14:24

mmorhun merged commit ecdb54e into eclipse-che:master Sep 23, 2020

che-bot added this to the 7.20 milestone Sep 23, 2020

che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: kubernetes keycloak deployment strategy #17304

feat: kubernetes keycloak deployment strategy #17304

kesslerdev commented Jul 1, 2020

sleshchenko Jul 2, 2020

kesslerdev Jul 2, 2020

kesslerdev Jul 2, 2020

che-bot commented Jul 2, 2020

che-bot commented Jul 2, 2020

tolusha commented Jul 15, 2020

dmytro-ndp commented Jul 15, 2020

dmytro-ndp commented Jul 15, 2020

che-bot commented Jul 15, 2020

dmytro-ndp commented Jul 15, 2020 •

edited

Loading

che-bot commented Jul 15, 2020

tolusha commented Jul 15, 2020

che-bot commented Jul 15, 2020

tolusha commented Jul 29, 2020

che-bot commented Jul 29, 2020

mmorhun commented Jul 29, 2020

mmorhun commented Aug 19, 2020

che-bot commented Aug 19, 2020

Ohrimenko1988 commented Aug 20, 2020

che-bot commented Aug 20, 2020

flacatus commented Aug 27, 2020

che-bot commented Aug 27, 2020

dmytro-ndp commented Aug 27, 2020

mmorhun commented Sep 16, 2020

kesslerdev commented Sep 21, 2020

tolusha commented Sep 22, 2020

che-bot commented Sep 22, 2020

flacatus commented Sep 22, 2020

che-bot commented Sep 22, 2020

tolusha commented Sep 23, 2020

benoitf commented Sep 23, 2020

mmorhun commented Sep 23, 2020

feat: kubernetes keycloak deployment strategy #17304

feat: kubernetes keycloak deployment strategy #17304

Conversation

kesslerdev commented Jul 1, 2020

What does this PR do?

sleshchenko Jul 2, 2020

Choose a reason for hiding this comment

kesslerdev Jul 2, 2020

Choose a reason for hiding this comment

kesslerdev Jul 2, 2020

Choose a reason for hiding this comment

che-bot commented Jul 2, 2020

che-bot commented Jul 2, 2020

tolusha commented Jul 15, 2020

dmytro-ndp commented Jul 15, 2020

dmytro-ndp commented Jul 15, 2020

che-bot commented Jul 15, 2020

dmytro-ndp commented Jul 15, 2020 • edited Loading

che-bot commented Jul 15, 2020

tolusha commented Jul 15, 2020

che-bot commented Jul 15, 2020

tolusha commented Jul 29, 2020

che-bot commented Jul 29, 2020

mmorhun commented Jul 29, 2020

mmorhun commented Aug 19, 2020

che-bot commented Aug 19, 2020

Ohrimenko1988 commented Aug 20, 2020

che-bot commented Aug 20, 2020

flacatus commented Aug 27, 2020

che-bot commented Aug 27, 2020

dmytro-ndp commented Aug 27, 2020

mmorhun commented Sep 16, 2020

kesslerdev commented Sep 21, 2020

tolusha commented Sep 22, 2020

che-bot commented Sep 22, 2020

flacatus commented Sep 22, 2020

che-bot commented Sep 22, 2020

tolusha commented Sep 23, 2020

benoitf commented Sep 23, 2020

mmorhun commented Sep 23, 2020

dmytro-ndp commented Jul 15, 2020 •

edited

Loading