Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add registerWith* properties for register template #17893

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Add registerWith* properties for register template #17893

merged 4 commits into from
Sep 17, 2020

Conversation

tolusha
Copy link
Contributor

@tolusha tolusha commented Sep 17, 2020

Signed-off-by: Anatolii Bazko abazko@redhat.com

What does this PR do?

Fix user registration template.

Screenshot/screencast of this PR

Before:
Screenshot from 2020-09-17 09-57-59

After:
Screenshot from 2020-09-17 10-35-17

What issues does this PR fix or reference?

#14083

How to test this PR?

  1. Build keycloak image
  2. Use keycloak image in keycloak deployment

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@tolusha
Add registerWith* properties for register template
d3e6b6e 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha tolusha mentioned this pull request Sep 17, 2020
Closed
48 tasks
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Sep 17, 2020
@che-bot
Copy link
Contributor

che-bot commented Sep 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@tolusha
Copy link
Contributor Author

tolusha commented Sep 17, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Sep 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@tolusha
Copy link
Contributor Author

tolusha commented Sep 17, 2020

[crw-ci-test]

skabashnyuk
skabashnyuk approved these changes Sep 17, 2020
View reviewed changes
dockerfiles/keycloak/che/login/messages/messages_en.properties Outdated
@@ -6,3 +6,6 @@ formRegister=Create an account with a form
passwordRecover=Forgot your password? <br/> Enter your email below.

usernameTitle=Username has to comply with the DNS naming convention. An alphanumeric (a-z, and 0-9) string, with a maximum length of 63 characters, with the '-' character allowed anywhere except the first or last character.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need new lines between properties?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, removed.

@tolusha
Remove empty lines
d32d4b2 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Remove empty lines
aa4111b 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@tolusha
Remove empty lines
bd046f6 
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Sep 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@tolusha
Copy link
Contributor Author

tolusha commented Sep 17, 2020

[crw-ci-test]

@tolusha
Copy link
Contributor Author

tolusha commented Sep 17, 2020

The only failed test is Language_server_validation_Java_LS_initialization, related issue #17864

@tolusha tolusha merged commit 2dbbe94 into master Sep 17, 2020
@tolusha tolusha deleted the fixregisterpage branch September 17, 2020 09:54
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Sep 17, 2020
@che-bot
Copy link
Contributor

che-bot commented Sep 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

@che-bot che-bot added this to the 7.19 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@l0rd l0rd Awaiting requested review from l0rd

@nickboldt nickboldt Awaiting requested review from nickboldt

Assignees
No one assigned
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Milestone
7.19
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tolusha @che-bot @skabashnyuk