feat(intellij): Add intellij as liveness probe #17998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
requested review from
ibuziuk,
l0rd,
nickboldt and
sleshchenko
as code owners
che-bot
added
status/code-review
This comment has been minimized.
This comment has been minimized.
|
[crw-ci-test] |
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
Related to eclipse-che#17790 Change-Id: I07b6c4b02bcb1e7fd9725e2e640f7c7e0d66aee2 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
skabashnyuk
approved these changes
Oct 1, 2020
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1) |
che-bot
removed
the
status/code-review
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add intellij as a liveness probe. Else we can redirect to the che editor before it's really available
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
Related to:
How to test this PR?
Build che server and use intellij for liveness probe
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or referenceandHow to test this PRcompletedReviewers
Reviewers, please comment how you tested the PR when approving it.
Change-Id: I07b6c4b02bcb1e7fd9725e2e640f7c7e0d66aee2
Signed-off-by: Florent Benoit fbenoit@redhat.com