Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Dashboard with Dashboard Next #18549

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Replace Dashboard with Dashboard Next #18549

merged 1 commit into from
Jan 22, 2021

Conversation

sleshchenko
Copy link
Member

@sleshchenko sleshchenko commented Dec 7, 2020 •
edited
Loading

What does this PR do?

This PR replaces Dashboard with Dashboard Next.

Related PRs:

Screenshot/screencast of this PR

Screenshot_20201207_150533
Screenshot_20201207_150542
Screenshot_20201207_151012

What issues does this PR fix or reference?

#18348

How to test this PR?

  1. Deploy Che from the PR.
  2. Make sure Dashboard Next replaces Dashboard and works fine.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Dec 7, 2020
@sleshchenko sleshchenko force-pushed the onlyDashboardNext branch 2 times, most recently from f65e1a6 to 9b83375 Compare December 28, 2020 17:28
@che-bot
Copy link
Contributor

che-bot commented Jan 12, 2021

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@che-bot
Copy link
Contributor

che-bot commented Jan 12, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

This was referenced Jan 12, 2021
Closed
Closed
Merged
Merged
@che-bot
Copy link
Contributor

che-bot commented Jan 22, 2021

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@sleshchenko sleshchenko mentioned this pull request Jan 22, 2021
Merged
@sleshchenko sleshchenko marked this pull request as ready for review January 22, 2021 13:56
nickboldt
nickboldt approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sleshchenko sleshchenko added this to the 7.26 milestone Jan 22, 2021
@sleshchenko sleshchenko merged commit 83d797f into eclipse-che:master Jan 22, 2021
@sleshchenko sleshchenko deleted the onlyDashboardNext branch January 22, 2021 14:23
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jan 22, 2021
@sleshchenko sleshchenko mentioned this pull request Jan 22, 2021
Closed
@sleshchenko sleshchenko mentioned this pull request Jan 22, 2021
Merged
6 tasks
mkuznyetsov added a commit that referenced this pull request Jan 25, 2021
@mkuznyetsov
Revert "Replace Dashboard with Dashboard Next (#18549)"
15b4d55 
This reverts commit 83d797f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olexii4 olexii4 olexii4 left review comments

@nickboldt nickboldt nickboldt approved these changes

@tolusha tolusha tolusha approved these changes

@benoitf benoitf Awaiting requested review from benoitf

Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
7.26
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sleshchenko @che-bot @nickboldt @tolusha @olexii4