Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wait dashboard after login #22180

Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: wait dashboard after login #22180

merged 1 commit into from
Apr 26, 2023

Conversation

nallikaea
Copy link
Contributor

What does this PR do?

  • added waiter for Dashboard page after login;
  • moved constants into class in RedHatLoginPage

Screenshot/screencast of this PR

image

What issues does this PR fix or reference?

Jenkins job

How to test this PR?

npm run test or re-run job.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Signed-off-by: mdolhalo <mdolhalo@redhat.com>
@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master. labels Apr 26, 2023
@nallikaea nallikaea self-assigned this Apr 26, 2023
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge.

@dmytro-ndp dmytro-ndp merged commit 5e8a484 into eclipse-che:main Apr 26, 2023
1 check passed
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants