Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude devworkspace-generator from the sed #22257

Merged
merged 1 commit into from
May 31, 2023
Merged

Exclude devworkspace-generator from the sed #22257

merged 1 commit into from
May 31, 2023

Conversation

SDawley
Copy link
Contributor

@SDawley SDawley commented May 31, 2023

Fixing the release issue the way it should have been fixed in the first place.
@eclipse-che/che-devworkspace-generator needed to be added to the list of exclusions from the sed that set all the versions to the release version in the package.json.

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels May 31, 2023
Copy link
Contributor

@amisevsk amisevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I parsed this sed command right after a dive into the documentation :)

@SDawley SDawley merged commit 62bfc1e into main May 31, 2023
1 check passed
@SDawley SDawley deleted the theGoodFix branch May 31, 2023 23:58
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants