Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools week che dogfooding test development #22282

Conversation

ScrewTSW
Copy link
Contributor

What does this PR do?

  • Modifies existing devfile to allow for development of Che/DevSpaces tests on Che Dogfooding instance

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

#22191

How to test this PR?

  • Apply this fork as a factory to dogfooding and try to run the described command

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. kind/task Internal things, technical debt, and to-do tasks to be performed. labels Jun 12, 2023
.devfile.yaml Outdated Show resolved Hide resolved
@nallikaea
Copy link
Contributor

@ScrewTSW which branch do you use to develop this issue? Looks it a long time outdated
image

@ScrewTSW
Copy link
Contributor Author

@ScrewTSW which branch do you use to develop this issue? Looks it a long time outdated

yes, that's true. I've forked it quite some time ago and did not rebase in a while.

@ScrewTSW ScrewTSW force-pushed the devtools-week-che-dogfooding-test-development branch 13 times, most recently from 96c9c6f to 85b433f Compare September 18, 2023 01:05
@ScrewTSW ScrewTSW force-pushed the devtools-week-che-dogfooding-test-development branch from 85b433f to c9ca4b4 Compare October 18, 2023 14:42
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
…capabilities

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
@ScrewTSW ScrewTSW force-pushed the devtools-week-che-dogfooding-test-development branch from c9ca4b4 to 089cb7b Compare October 18, 2023 14:43
@ScrewTSW
Copy link
Contributor Author

@ScrewTSW which branch do you use to develop this issue? Looks it a long time outdated image

updated

@ScrewTSW ScrewTSW force-pushed the devtools-week-che-dogfooding-test-development branch from b10a181 to 39c410c Compare October 18, 2023 14:58
@dmytro-ndp
Copy link
Contributor

@ScrewTSW : while workspace has been successfully loaded with factory URL from the branch https://github.com/ScrewTSW/che/tree/devtools-week-che-dogfooding-test-development, I found devfile commands not working correctly when run from top menu "Terminal > Run Task..." in VS Code Editor:

 *  Executing task: devfile: tests-happy-path-remote 

sh: -c: line 0: syntax error near unexpected token `('
sh: -c: line 0: `cd /projects/che; export HAPPY_PATH_USERSTORY=SmokeTest && export HAPPY_PATH_SUITE=test && export MOCHA_DIRECTORY='.' && bash <(curl -s https://raw.githubusercontent.com/eclipse/che/main/tests/devworkspace-happy-path/remote-launch.sh)'

 *  The terminal process failed to launch (exit code: 1). 
 *  Terminal will be reused by tasks, press any key to close it. 
 *  Executing task: devfile: tests-build-tests 


> @eclipse-che/che-e2e@7.76.0-next tsc
> rm -rf ./dist && ./configs/sh-scripts/generateIndex.sh && tsc -p .

Generating index.ts file...
sh: tsc: command not found

 *  The terminal process terminated with exit code: 1. 
 *  Terminal will be reused by tasks, press any key to close it. 
 *  Executing task: devfile: check-contributing-is-updated 

sh: .repositories-update-contributing.sh: command not found

 *  The terminal process failed to launch (exit code: 1). 
 *  Terminal will be reused by tasks, press any key to close it. 
 *  Executing task: devfile: tests-lint-project 


> @eclipse-che/che-e2e@7.76.0-next lint
> eslint --fix .

sh: eslint: command not found

 *  The terminal process terminated with exit code: 1. 
 *  Terminal will be reused by tasks, press any key to close it. 
 *  Executing task: devfile: tests-update-dependencies 

Updating nodejs
sh: nvm: command not found

 *  The terminal process failed to launch (exit code: 1). 
 *  Terminal will be reused by tasks, press any key to close it. 

Is there a chance you could make devfile commands working?

@ScrewTSW ScrewTSW force-pushed the devtools-week-che-dogfooding-test-development branch 2 times, most recently from 95323c1 to a8559cf Compare October 24, 2023 10:36
@ScrewTSW ScrewTSW force-pushed the devtools-week-che-dogfooding-test-development branch 8 times, most recently from 259eed5 to ba4d49f Compare October 24, 2023 11:42
…odeJS to lts/hydrogen (nodejs 18)

Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
@ScrewTSW ScrewTSW force-pushed the devtools-week-che-dogfooding-test-development branch from ba4d49f to 1b224f3 Compare October 24, 2023 12:36
@dmytro-ndp dmytro-ndp marked this pull request as ready for review October 24, 2023 16:25
@dmytro-ndp
Copy link
Contributor

@ScrewTSW : thank you for the fix of commands!
Everything works correctly now, but update-contributing:

 *  Executing task: devfile: update-contributing 

sh: .repositories-update-contributing.sh: command not found

 *  The terminal process failed to launch (exit code: 1). 
 *  Terminal will be reused by tasks, press any key to close it. 

Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge (assuming that PR has nothing with update-contributing devfile command).

@ibuziuk
Copy link
Member

ibuziuk commented Jan 23, 2024

@dmytro-ndp this looks like useful PR
maybe you can take over it in the next sprint update & merge?

@ibuziuk ibuziuk mentioned this pull request Jan 30, 2024
24 tasks
@ibuziuk
Copy link
Member

ibuziuk commented Feb 29, 2024

@musienko-maxim please, update the PR so that we can merge it

@ScrewTSW ScrewTSW requested a review from SDawley as a code owner March 1, 2024 13:55
@dmytro-ndp dmytro-ndp merged commit bdad2b7 into eclipse-che:main Mar 1, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants