-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devtools week che dogfooding test development #22282
Devtools week che dogfooding test development #22282
Conversation
@ScrewTSW which branch do you use to develop this issue? Looks it a long time outdated |
yes, that's true. I've forked it quite some time ago and did not rebase in a while. |
96c9c6f
to
85b433f
Compare
85b433f
to
c9ca4b4
Compare
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
…capabilities Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
c9ca4b4
to
089cb7b
Compare
updated |
b10a181
to
39c410c
Compare
@ScrewTSW : while workspace has been successfully loaded with factory URL from the branch https://github.com/ScrewTSW/che/tree/devtools-week-che-dogfooding-test-development, I found devfile commands not working correctly when run from top menu "Terminal > Run Task..." in VS Code Editor:
Is there a chance you could make devfile commands working? |
95323c1
to
a8559cf
Compare
259eed5
to
ba4d49f
Compare
…odeJS to lts/hydrogen (nodejs 18) Signed-off-by: Tibor Dancs <tdancs@redhat.com>
Signed-off-by: Tibor Dancs <tdancs@redhat.com>
ba4d49f
to
1b224f3
Compare
@ScrewTSW : thank you for the fix of commands!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge (assuming that PR has nothing with update-contributing
devfile command).
@dmytro-ndp this looks like useful PR |
@musienko-maxim please, update the PR so that we can merge it |
What does this PR do?
Screenshot/screencast of this PR
N/A
What issues does this PR fix or reference?
#22191
How to test this PR?
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.