Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Che CLI: added some parameters to execute che-mount #2523

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

l0rd
Copy link
Contributor

@l0rd l0rd commented Sep 21, 2016

What does this PR do?

Adapt Che CLI to the che-mount updates introduced by eclipse-che/che-dockerfiles#18:

  • Fix local synched folder permissions on Linux
  • Persist workspace SSH ECDSA key fingerprint in local ~/.ssh/known_hosts

What issues does this PR fix or reference?

@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf
Copy link
Contributor

benoitf commented Sep 21, 2016

how to provide custom ssh key if it's not stored in user home folder ?

for example with che dir up, ssh files are stored in the .che directory
is that an option to provide private key is possible ?

for example sshfs option seems to be
-o IdentityFile=/path/to/key

@l0rd
Copy link
Contributor Author

l0rd commented Sep 21, 2016

@benoitf This PR do not address that. Using option IdentityFile would be a way to do that or we can just run che-mount using volume -v /path/to/key:${HOME}/.ssh/key

Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
@l0rd l0rd mentioned this pull request Sep 21, 2016
@TylerJewell TylerJewell added the kind/enhancement A feature request - must adhere to the feature request template. label Sep 21, 2016
@TylerJewell TylerJewell added this to the 5.0.0-M3 milestone Sep 21, 2016
@TylerJewell TylerJewell merged commit 5c27745 into eclipse-che:master Sep 21, 2016
@bmicklea bmicklea mentioned this pull request Sep 28, 2016
63 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Signed-off-by: Mario Loriedo <mloriedo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants