Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish StackPersistedEvent after stack is persisted #2582

Merged
merged 1 commit into from
Sep 26, 2016
Merged

Publish StackPersistedEvent after stack is persisted #2582

merged 1 commit into from
Sep 26, 2016

Conversation

voievodin
Copy link
Contributor

What does this PR do?

Adds a new StackPersitedEvent which is published after stack is persisted.
Declares StackLoader to be initialized after EntityListenerInjectionManagerInitializer is initalized

PR type

  • Minor change = no change to existing features or docs
  • Major change = changes existing features or docs

Minor change checklist

  • New API required?
  • API updated
  • Tests provided / updated
  • Tests passed

@skabashnyuk please review

@voievodin voievodin mentioned this pull request Sep 24, 2016
Merged
@codenvy-ci
Copy link

Build # 508 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/508/ to view the results.

sleshchenko
sleshchenko approved these changes Sep 26, 2016
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@voievodin voievodin added this to the 5.0.0-M3 milestone Sep 26, 2016
@voievodin voievodin merged commit e5212bd into master Sep 26, 2016
@voievodin voievodin deleted the fix_stacks branch September 26, 2016 07:23
@bmicklea bmicklea mentioned this pull request Sep 28, 2016
Closed
63 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Publish StackPersistedEvent after stack is persisted (eclipse-che#2582)
90b7609
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skabashnyuk skabashnyuk skabashnyuk approved these changes

@sleshchenko sleshchenko sleshchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0-M3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@voievodin @codenvy-ci @skabashnyuk @sleshchenko