Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-3218: improves the documentation popup for LSP code completion #3224

Merged
merged 1 commit into from
Jan 12, 2017

Conversation

kaloyan-raev
Copy link
Contributor

@kaloyan-raev kaloyan-raev commented Dec 1, 2016

What does this PR do?

Improves the documentation popup for LSP code completion.

What issues does this PR fix or reference?

Fixes #3218

Previous behavior

image

New behavior

  • Scrollbars when necessary
  • HTML tags are rendered
  • Possible to select and copy some text from the documentation
  • No flickering while typing

image

Signed-off-by: Kaloyan Raev kaloyan.r@zend.com

Signed-off-by: Kaloyan Raev <kaloyan.r@zend.com>
@kaloyan-raev
Copy link
Contributor Author

ci-build

@codenvy-ci
Copy link

Can one of the admins verify this patch?

@kaloyan-raev
Copy link
Contributor Author

ci-build

@kaloyan-raev
Copy link
Contributor Author

@benoitf I am a committer now, but the "ci-build" trick does not seem to work for me. Could you check if any configuration needs to be done?

@TylerJewell
Copy link

@kaloyan-raev @vparfonov - let's have this merged. If there are open questions for Kaloyan, then we should get those addressed.

@benoitf
Copy link
Contributor

benoitf commented Jan 8, 2017

ci-build

@codenvy-ci
Copy link

Build # 1545 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/1545/ to view the results.

@vparfonov vparfonov merged commit 282945b into master Jan 12, 2017
@vparfonov vparfonov deleted the CHE-3218 branch January 12, 2017 21:49
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with documentation popup for LSP code completion
5 participants