Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-249: Setting workspace Pod terminationGracePeriodSeconds to zero #5773

Merged
merged 1 commit into from Jul 24, 2017
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Expand Up @@ -177,6 +177,8 @@ public class OpenShiftConnector extends DockerConnector {
private static final int OPENSHIFT_WAIT_POD_TIMEOUT = 240;
private static final int OPENSHIFT_IMAGESTREAM_WAIT_DELAY = 2000;
private static final int OPENSHIFT_IMAGESTREAM_MAX_WAIT_COUNT = 30;
private static final long OPENSHIFT_POD_TERMINATION_GRACE_PERIOD = 0;

private static final String OPENSHIFT_POD_STATUS_RUNNING = "Running";
private static final String OPENSHIFT_VOLUME_STORAGE_CLASS = "volume.beta.kubernetes.io/storage-class";
private static final String OPENSHIFT_VOLUME_STORAGE_CLASS_NAME = "che-workspace";
Expand Down Expand Up @@ -1203,6 +1205,7 @@ private void createOpenShiftDeployment(String deploymentName,
PodSpec podSpec = new PodSpecBuilder()
.withContainers(container)
.withVolumes(getVolumesFrom(volumes))
.withTerminationGracePeriodSeconds(OPENSHIFT_POD_TERMINATION_GRACE_PERIOD)
.build();

Deployment deployment = new DeploymentBuilder()
Expand Down