CHE-6162: Fix problem project detection procedure #6264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
vparfonov
added
kind/bug
|
Build # 3670 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3670/ to view the results. |
garagatyi
approved these changes
Sep 14, 2017
vzhukovs
reviewed
Sep 14, 2017
| @@ -96,6 +97,11 @@ public SourceStorage getSource() { | |||
| return reference.getSource(); | |||
| } | |||
|
|
|||
| @Override | |||
| public List<ProjectProblem> getProblems() { | |||
| return null; | |||
There was a problem hiding this comment.
Maybe it would be better to return actual list of problems? reference.getProblems() WDYT?
vzhukovs
reviewed
Sep 14, 2017
| @@ -189,6 +193,7 @@ public void updatePresentation(@NotNull NodePresentation presentation) { | |||
| ? nodesResources.hiddenSimpleFolder() | |||
| : nodesResources.simpleFolder()); | |||
| } else if (getData().getResourceType() == PROJECT) { | |||
| Log.info(getClass(), ((Project) getData()).isProblem()); | |||
vzhukovs
approved these changes
Sep 14, 2017
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
Signed-off-by: Vitalii Parfonov <vparfonov@redhat.com>
|
Build # 3684 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3684/ to view the results. |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3685/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix problem project detection procedure.
Avoid call ResourceNode.updatePresntation if not need
What issues does this PR fix or reference?
#6162