Rework and add test for checking of Test Runner plugin #6401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musienko-maxim
force-pushed
the
CHE#6332
branch
from
6140007
to
a9e1e6d
Compare
musienko-maxim
requested review from
ashumilova,
azatsarynnyy,
benoitf,
dkuleshov,
evidolob,
garagatyi,
l0rd,
riuvshin and
skabashnyuk
as code owners
musienko-maxim
force-pushed
the
CHE#6332
branch
from
a9e1e6d
to
d3c23df
Compare
musienko-maxim
removed request for
benoitf,
l0rd,
evidolob,
ashumilova,
skabashnyuk,
dkuleshov,
azatsarynnyy and
riuvshin
|
ci-build |
garagatyi
reviewed
Sep 25, 2017
| ws.getId(), | ||
| Paths.get(resource.toURI()), |
There was a problem hiding this comment.
Consider porting this class to master to avoid painful merge conflicts.
vparfonov
reviewed
Sep 25, 2017
| assertTrue(pluginConsole.getAllMethodsMarkedDefinedStatus(PASSED).size() == 1); | ||
| assertTrue(pluginConsole.getAllMethodsMarkedDefinedStatus(FAILED).size() == 1); | ||
| Assert.assertTrue(pluginConsole.getAllNamesOfMethodsMarkedDefinedStatus(PASSED).size() == 1); | ||
| Assert.assertTrue(pluginConsole.getAllNamesOfMethodsMarkedDefinedStatus(FAILED).size() == 1); | ||
| String testErrorMessage = pluginConsole.getTestErrorMessage(); | ||
| assertTrue( |
There was a problem hiding this comment.
use static import everywhere if you star using it
musienko-maxim
force-pushed
the
CHE#6332
branch
from
43ae545
to
27e9b0d
Compare
vparfonov
approved these changes
Sep 25, 2017
tolusha
requested changes
Sep 26, 2017
| * | ||
| * @param xoffset offset in pixels for shifting | ||
| */ | ||
| public void dragConsolesInDefinePosition(int xoffset) { |
There was a problem hiding this comment.
If the name of the method is self descriptive I don't want to see any java doc.
Review all javadocs you have added in this PR. https://dev.liferay.com/participate/javadoc-guidelines
There was a problem hiding this comment.
The name of the variables xoffset seems weird.
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| public class JavaTestPluginJuinit4CheckRunSuitesAndScopesTest { |
There was a problem hiding this comment.
Typo in the name of the class
| projectExplorer.waitItem(JUNIT4_PROJECT); | ||
| runCompileCommandByPallete(compileCommand); | ||
| notifications.waitProgressPopupPanelClose(); | ||
| consoles.dragConsolesInDefinePosition(-100); |
| + " at org.junit.Assert.assertFalse(Assert.java:64)\n" | ||
| + " at org.junit.Assert.assertFalse(Assert.java:74)\n" | ||
| + " at org.eclipse.che.examples.AppAnotherTest.shouldFailOfAppAnother(AppAnotherTest.java:33)"; | ||
| + " at org.junit. fail( java:86)\n" |
There was a problem hiding this comment.
It is weird to see a space before method.
tolusha
reviewed
Sep 27, 2017
| import org.testng.annotations.BeforeClass; | ||
| import org.testng.annotations.Test; | ||
|
|
||
| public class JavaTestPluginJunit4CheckRunSuitesAndScopesTest { |
tolusha
reviewed
Sep 27, 2017
| } | ||
|
|
||
| /** | ||
| * click on the item in the result tree. If will be some items with the same name - will select |
tolusha
approved these changes
Sep 28, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3865/ |
slemeur
added
the
kind/task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
@garagatyi, @vparfonov, @tolusha