che #6500 - Removing optional 'che-ws-' prefix during tag creation on OpenShift #6604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…creation Signed-off-by: Ilya Buziuk <ibuziuk@redhat.com>
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
benoitf
added
status/code-review
|
ci-build |
benoitf
approved these changes
Oct 6, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4026/ |
l0rd
approved these changes
Oct 9, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Buziuk ibuziuk@redhat.com
What does this PR do?
Removing optional 'che-ws-' prefix during tag creation OpenShift / k8s names / labels max length is 63 chars and removing optional prefix (7 chars) would allow creating multi-container workspaces on minishift
What issues does this PR fix or reference?
hot fix for #6500
docker image for testing
ibuziuk/che-server:chewsRemoving optional 'che-ws-' prefix during tag creation OpenShift
Release Notes
N / A
Docs PR
N / A