Move dependency declaration to che-deps repo #6606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skabashnyuk
added
kind/task
|
Should not we move jsr305 dependency also somewhere like |
|
Build # 4028 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4028/ to view the results. |
|
@sleshchenko we could but we don't want to. It's here because it's needed for gwt compilation. But we don't want to give developers signal to use it in compile scope mode because it's declared as build only. |
benoitf
added
the
target/branch
|
@skabashnyuk Thanks for explanation |
vparfonov
approved these changes
Oct 6, 2017
riuvshin
approved these changes
Oct 6, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move dependency declaration to che-deps repo
related to eclipse-che/che-dependencies#57
What issues does this PR fix or reference?
#5362
n/a
Release Notes
n/a
Docs PR
n/a