Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added style for css elements for css file types #7320

Merged
merged 1 commit into from Nov 14, 2017

Conversation

arunkumar413
Copy link
Contributor

What does this PR do?

This pull request changes the font color of css property while editing a css file.

What issues does this PR fix or referenced?

#7257
The font color of a css property is blue in color and it's not correctly visible when used with dark theme. So I just changed the color so that it's clearly visible in the dark theme

Docs PR

@codenvy-ci
Copy link

Can one of the admins verify this patch?

1 similar comment
@codenvy-ci
Copy link

Can one of the admins verify this patch?

@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels Nov 11, 2017
@ashumilova ashumilova added this to the 6.0.0-M2 milestone Nov 12, 2017
@ashumilova
Copy link
Contributor

screenshot from 2017-11-13 10-08-37
screenshot from 2017-11-13 10-09-36

@slemeur
Copy link
Contributor

slemeur commented Nov 13, 2017

Awesome @arunkumar413 ! Love it !
Before we can merge your PR, we need you to sign the Eclipse Contributor Licence Agreement. If you have not yet signed it, you can check the following page
Also, we'll need your commit to be signed-off.

More info

Once the CLA is valid, will merge the PR asap.

@ashumilova : This PR targets master. Not che 6 branch. Could you please change the milestone and apply to che 6 branch too?

@arunkumar413
Copy link
Contributor Author

@slemeur,

I signed the Eclipse Contributor Licence Agreement

@ashumilova ashumilova modified the milestones: 6.0.0-M2, 5.21.0 Nov 14, 2017
@ashumilova ashumilova merged commit cd6ca0f into eclipse-che:master Nov 14, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 14, 2017
@arunkumar413
Copy link
Contributor Author

Is this fix in production? I don't see the changes in code envy interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants