Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the query parameters on loading IDE #7428

Merged
merged 1 commit into from
Nov 17, 2017
Merged

Cache the query parameters on loading IDE #7428

merged 1 commit into from
Nov 17, 2017

Conversation

azatsarynnyy
Copy link
Member

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

org.eclipse.che.ide.QueryParameters must cache URL query parameters because it's impossible to get them after IDE changes window's location.

What issues does this PR fix or reference?

needed for #6713

Release Notes

Docs PR

…ecause IDE changes window's location

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@azatsarynnyy azatsarynnyy added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/che6 labels Nov 17, 2017
@azatsarynnyy azatsarynnyy merged commit d4970fa into che6 Nov 17, 2017
@azatsarynnyy azatsarynnyy deleted the queryparams branch November 17, 2017 12:10
@azatsarynnyy azatsarynnyy removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 17, 2017
@azatsarynnyy azatsarynnyy added this to the 6.0.0-M2 milestone Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants