Fix bug in AskForValueDialog in typeAndWaitText method #7545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f2ca2fa)
Ohrimenko1988
added
status/code-review
dmytro-ndp
reviewed
Nov 24, 2017
| @@ -137,7 +138,10 @@ public void clickCancelButtonJava() { | |||
| } | |||
|
|
|||
| public void typeAndWaitText(String text) { | |||
| input.sendKeys(text); | |||
| waitFormToOpen(); | |||
There was a problem hiding this comment.
It should be checked before the call of the method.
dmytro-ndp
reviewed
Nov 24, 2017
| @@ -137,7 +138,10 @@ public void clickCancelButtonJava() { | |||
| } | |||
|
|
|||
| public void typeAndWaitText(String text) { | |||
| input.sendKeys(text); | |||
| waitFormToOpen(); | |||
| new WebDriverWait(seleniumWebDriver, TestTimeoutsConstants.LOAD_PAGE_TIMEOUT_SEC) | |||
There was a problem hiding this comment.
Good catch!
Lets extract new WebDriverWait(seleniumWebDriver, TestTimeoutsConstants.LOAD_PAGE_TIMEOUT_SEC) into the separate constant and add similar verification in other methods.
tolusha
approved these changes
Nov 24, 2017
dmytro-ndp
reviewed
Nov 24, 2017
| loadPageWait.until(visibilityOf(inputNameJavaClass)).sendKeys(text); | ||
| } | ||
|
|
||
| public void waitTextInFieldName(String expectedText) { |
There was a problem hiding this comment.
IMHO it's better to enclose call of this method into the typeTextInFieldName() in similar way, as it was done for waitInputNameContains() method.
dmytro-ndp
reviewed
Nov 24, 2017
| @@ -31,11 +31,11 @@ che.selenium.infrastructure=docker | |||
| # Define configuration for che default test user. | |||
| # For che single user assembly, the default values will be enough. | |||
| # For che multiuser assembly, user must be already created on identity provider service. | |||
| che.test_user.email=che@eclipse.org | |||
| che.test_user.password=secret | |||
| che.test_user.email=admin@admin.com | |||
There was a problem hiding this comment.
Is it really what you wanted to change? :-)
dmytro-ndp
approved these changes
Nov 24, 2017
Ohrimenko1988
removed
the
status/code-review
benoitf
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix bug in AskForValueDialog in typeAndWaitText method
What issues does this PR fix or reference?
Issue #7543
Release Notes
Docs PR