Change worskpace project files storage path #7844
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,96 @@ | ||
| /* | ||
| * Copyright (c) 2012-2017 Red Hat, Inc. | ||
| * All rights reserved. This program and the accompanying materials | ||
| * are made available under the terms of the Eclipse Public License v1.0 | ||
| * which accompanies this distribution, and is available at | ||
| * http://www.eclipse.org/legal/epl-v10.html | ||
| * | ||
| * Contributors: | ||
| * Red Hat, Inc. - initial API and implementation | ||
| */ | ||
| package org.eclipse.che.workspace.infrastructure.docker.local.projects; | ||
|
|
||
| import static org.eclipse.che.api.core.Pages.iterate; | ||
|
|
||
| import com.google.inject.Inject; | ||
| import java.io.IOException; | ||
| import java.nio.file.Files; | ||
| import java.nio.file.Path; | ||
| import java.nio.file.Paths; | ||
| import java.nio.file.StandardCopyOption; | ||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
| import java.util.Map.Entry; | ||
| import org.eclipse.che.api.core.ServerException; | ||
| import org.eclipse.che.api.workspace.server.model.impl.WorkspaceImpl; | ||
| import org.eclipse.che.api.workspace.server.spi.WorkspaceDao; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * Performs migration of workspace project files, that are stored in old format (in directories | ||
| * named after their workspace name), so they will be stored in folders named after their workspace | ||
| * ID. | ||
| * | ||
| * @author Mykhailo Kuznietsov | ||
| */ | ||
| public class LocalProjectsMigrator { | ||
|
|
||
| private final WorkspaceDao workspaceDao; | ||
|
|
||
| @Inject | ||
| public LocalProjectsMigrator(WorkspaceDao workspaceDao) { | ||
| this.workspaceDao = workspaceDao; | ||
| } | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(LocalProjectsMigrator.class); | ||
|
|
||
| public void performMigration(String workspaceProjectsRootFolder) { | ||
| LOG.debug("Starting migration of workspace project files"); | ||
|
|
||
| Map<String, String> workspaceName2id = getId2NameWorkspaceMapping(); | ||
| for (Entry<String, String> entry : workspaceName2id.entrySet()) { | ||
| Path workspaceStoredByNameLocation = | ||
| Paths.get(workspaceProjectsRootFolder).resolve(entry.getValue()); | ||
| if (!Files.exists(workspaceStoredByNameLocation)) { | ||
| // migration is not needed for this workspace | ||
| continue; | ||
| } | ||
| LOG.debug( | ||
| "Performing migration of workspace with id '{}' and name '{}'", | ||
| entry.getKey(), | ||
| entry.getValue()); | ||
| Path workspaceStoredByIdLocation = | ||
| Paths.get(workspaceProjectsRootFolder).resolve(entry.getKey()); | ||
| try { | ||
| Files.move( | ||
| workspaceStoredByNameLocation, | ||
| workspaceStoredByIdLocation, | ||
| StandardCopyOption.ATOMIC_MOVE); | ||
| LOG.info( | ||
|
There was a problem hiding this comment. I'd change info level here to debug. There was a problem hiding this comment. no, stay with info. We need to provide this information to the user. |
||
| "Successfully migrated projects of workspace with id '{}' and name '{}'", | ||
| entry.getKey(), | ||
| entry.getValue()); | ||
| } catch (IOException e) { | ||
| LOG.debug( | ||
|
|
||
| "Failed to migrate projects of workspace with id '{}' and name '{}'", | ||
| entry.getKey(), | ||
| entry.getValue()); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private Map<String, String> getId2NameWorkspaceMapping() { | ||
| try { | ||
| Map<String, String> result = new HashMap<>(); | ||
|
|
||
| for (WorkspaceImpl workspace : | ||
| iterate( | ||
|
There was a problem hiding this comment. Iterate will eager fetch all objects from a database. I'd be nice to check how many memory it will consume when a number of workspaces is like 50 000 or the same as we have on There was a problem hiding this comment. I think that's unnecessary, I don't think there will ever happen a migration of significant size of workspaces, ever. |
||
| (maxItems, skipCount) -> workspaceDao.getWorkspaces(false, maxItems, skipCount))) { | ||
| result.put(workspace.getId(), workspace.getConfig().getName()); | ||
| } | ||
| return result; | ||
| } catch (ServerException e) { | ||
| throw new RuntimeException(e); | ||
| } | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it be only for che.infra.docker ? (prefix)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I was not able to protect such a naming when Tyler did choose another naming technique. I don't remember that anyone was supporting me at that point. Does it seem better now?