Selenium: update the ConvertToProjectWithPomFileTest selenium test #7945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 15, 2017 15:54
…ertToProjectWithPomFileTestChe6
…that after refreshine web page the Editor tab name is not changed
SkorikSergey
added
kind/task
dmytro-ndp
reviewed
Dec 19, 2017
| ide.open(workspace); | ||
| projectExplorer.waitProjectExplorer(); |
There was a problem hiding this comment.
Why do we need to open project in setUp()?
It's better to do it in the appropriate tests to avoid skipping of all tests execution in case of error, and to prevent duplication of code.
Or expand full project tree at once.
dmytro-ndp
reviewed
Dec 19, 2017
| editor.deleteAllContent(); | ||
| actionsFactory.createAction(seleniumWebDriver).sendKeys(EXPECTED_TEXT).perform(); | ||
| editor.waitTextIntoEditor(EXPECTED_TEXT); | ||
| WaitUtils.sleepQuietly(5); |
There was a problem hiding this comment.
too big sleep. Please, add explanation why it is needed.
dmytro-ndp
reviewed
Dec 19, 2017
| editor.waitTabIsPresent("qa-spring-sample"); | ||
| editor.goToCursorPositionVisible(18, 17); | ||
| editor.typeTextIntoEditor("new-"); | ||
| WaitUtils.sleepQuietly(5); |
There was a problem hiding this comment.
too big sleep. Please, add explanation why it is needed.
|
ci-build |
dmytro-ndp
reviewed
Dec 19, 2017
| editor.waitActive(); | ||
| editor.waitTabIsPresent("pom.xml"); | ||
| editor.deleteAllContent(); | ||
| actionsFactory.createAction(seleniumWebDriver).sendKeys(EXPECTED_TEXT).perform(); | ||
| editor.waitTextIntoEditor(EXPECTED_TEXT); | ||
|
|
||
| // this timeout need for waiting that the Editor tab name of 'pom.xml' file is changed |
dmytro-ndp
reviewed
Dec 19, 2017
| @@ -124,6 +124,8 @@ public void checkEditorTabNameAfterChangingArtifactID() { | |||
| editor.waitTabIsPresent("qa-spring-sample"); | |||
| editor.goToCursorPositionVisible(18, 17); | |||
| editor.typeTextIntoEditor("new-"); | |||
|
|
|||
| // this timeout need for waiting that the Editor tab name of 'pom.xml' file is changed | |||
dmytro-ndp
approved these changes
Dec 19, 2017
tolusha
approved these changes
Dec 19, 2017
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4402/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR:
What issues does this PR fix or reference?
#7831