Selenium: add selenium test to check the workspace details of workspace with single machine #7946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
December 14, 2017 12:31
…eTest and WorkspaceDetailsSingleMachineTest
…spaceDetailsSeleniumTestChe6
…spaceDetailsSeleniumTestChe6
…ace started before checking that 'machine' machine exists
SkorikSergey
added
kind/task
dmytro-ndp
reviewed
Dec 19, 2017
| @@ -177,6 +179,20 @@ public void waitReferenceIsNotPresent(String referenceId) { | |||
| redrawDriverWait.until(invisibilityOfElementLocated(By.id(referenceId))); | |||
| } | |||
|
|
|||
| public Boolean checkThatServerExists(String serverName) { | |||
There was a problem hiding this comment.
Do we really need Boolean here? May primitive type boolean be enough?
dmytro-ndp
reviewed
Dec 19, 2017
| loadPageDriverWait.until( | ||
| visibilityOfAllElementsLocatedBy( | ||
| By.xpath("//div[contains(@id, 'runtime-info-reference-')]"))); | ||
| for (WebElement we : webElements) { |
There was a problem hiding this comment.
Empty line above the for can improve readability of code.
dmytro-ndp
reviewed
Dec 19, 2017
| installers.put("TypeScript language server", false); | ||
| installers.put("Yaml language server", false); | ||
|
|
||
| private void createMap() { |
There was a problem hiding this comment.
You can replace the method by one command:
private static final Map<String, String> EXPECTED_VARIABLES = ImmutableMap.of("MYSQL_DATABASE", "petclinic",
"MYSQL_PASSWORD", "password",
"MYSQL_ROOT_PASSWORD", "password",
"MYSQL_USER", "petclinic");
dmytro-ndp
reviewed
Dec 19, 2017
| @BeforeClass | ||
| public void setUp() throws Exception { | ||
| workspaceName = testWorkspace.getName(); | ||
| createMap(); |
There was a problem hiding this comment.
this method could by replaced by the command:
private static final Map<String, Boolean> EXPECTED_INSTALLERS = ImmutableMap.<String, Boolean>builder()
.put("C# language server", false)
.put("Exec", false)
.put("File sync", false)
.put("Git credentials", false)
.put("JSON language server", false)
.put("PHP language server", false)
.put("Python language server", false)
.put("Simple Test language server", false)
.put("SSH", false)
.put("Terminal", true)
.put("TypeScript language server", false)
.put("Yaml language server", false)
.build();
|
ci-build |
tolusha
approved these changes
Dec 19, 2017
dmytro-ndp
approved these changes
Dec 19, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4401/ |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR create a selenium test for testing the workspace details of a workspace with single machine.
The existed WorkspaceDetailsTest selenium test splitted to WorkspaceDetailsSingleMachineTest and WorkspaceDetailsComposeTest tests.
In WorkspaceDetailsComposeTest will be tested the Machines and the Env Variables tabs in workspace created from the Java-MySql stack.
In WorkspaceDetailsSingleMachineTest will be tested the Overview, the Projects, the Installers and the Servers tabs.
What issues does this PR fix or reference?
#7919