Use trash icon from FontAwesome for delete command operation

[vzhukovs]

What does this PR do?

This changes proposal replaces current icon for delete command button with the new one used from Font Awesome:

Signed-off-by: Vladyslav Zhukovskyi vzhukovs@redhat.com

What issues does this PR fix or reference?

openshiftio/openshift.io#1502

Release Notes

N/A

Docs PR

N/A

[vzhukovs]

ci-build

[dkuleshov]

Hi,

Everything looks good, but I wonder what you think about the next thing. I'd rather added a separate method createButton(String) instead of making common method getIconElement, because though technically it is permissible, it seems to me a bit weird when you do icon instanceof String, because essentially icon and string are quite different entities. Or, by the way, we can have createButton(Element) and createButtonElement(SVGResource resource) and createButtonElement(String iHtmlTag)?

[codenvy-ci]

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4400/

[vzhukovs]

@dkuleshov it's not a problem to refactor this PR. The main reason why I'm comparing with String is that we have org.eclipse.che.ide.FontAwesome class where icons described as html strings. There isn't any impediments to create two separate private methods to process two types of icon.

[slemeur]

@vzhukovskii : Have you handle "deleting" using the keyboard ?

[slemeur]

This does not fix: #7715

[vzhukovs]

@slemeur no, this PR just changes the icon with the new one.

[slemeur]

so where are the other improvementS?

[ashumilova]

The PR handled the description of the following issue only - openshiftio/openshift.io#1502
this one will take into account - #7715