Make sure traefik runs in an openshift workspace #7955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
ghost
changed the title
benoitf
added
status/code-review
benoitf
reviewed
Dec 19, 2017
dockerfiles/dev/Dockerfile
Outdated
| @@ -60,12 +62,17 @@ RUN mkdir /home/user/traefik ;\ | |||
| wget -O /home/user/traefik/traefik "https://github.com/containous/traefik/releases/download/v1.4.3/traefik_linux-amd64"; \ | |||
| chmod +x /home/user/traefik/traefik | |||
| COPY traefik.toml /home/user/traefik/ | |||
| RUN sudo chgrp -R 0 ~/traefik;\ | |||
| sudo chmod -R g+rwX ~/traefik | |||
There was a problem hiding this comment.
can we group RUN instructions ?
benoitf
reviewed
Dec 19, 2017
dockerfiles/dev/Dockerfile
Outdated
|
|
||
|
|
||
| RUN sudo mkdir /var/run/sshd | ||
| RUN sudo ssh-keygen -t rsa -f /etc/ssh/ssh_host_rsa_key -N '' && \ | ||
| sudo ssh-keygen -t rsa -f /etc/ssh/ssh_host_ecdsa_key -N '' && \ | ||
| sudo ssh-keygen -t rsa -f /etc/ssh/ssh_host_ed25519_key -N '' && \ | ||
| npm install -g typescript@2.5.3 typescript-language-server@0.1.4 | ||
|
|
||
| ADD entrypoint.sh /home/user/entrypoint.sh | ||
| RUN sudo chmod +x /home/user/entrypoint.sh |
There was a problem hiding this comment.
do we need to chmod the file if file is committed with execute permissions ?
benoitf
reviewed
Dec 19, 2017
dockerfiles/dev/Dockerfile
Outdated
| WORKDIR /projects | ||
| ENTRYPOINT ["/home/user/entrypoint.sh"] | ||
| CMD tail -f /dev/null |
There was a problem hiding this comment.
there is a missing new line
benoitf
reviewed
Dec 19, 2017
| @@ -0,0 +1,32 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
copyright header is missing
benoitf
approved these changes
Dec 19, 2017
skabashnyuk
approved these changes
Dec 19, 2017
riuvshin
approved these changes
Dec 19, 2017
benoitf
removed
the
status/code-review
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets CHE_API for Traefik according to infra, adds sufficient permissions for tomcat and traefik