Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CHE-7139: Fix redraw selection on horizontal scroll. #8355

Merged
merged 8 commits into from
Jan 24, 2018
Merged

CHE-7139: Fix redraw selection on horizontal scroll. #8355

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2232ef0
Fix format.
AndrienkoAleksandr Jan 17, 2018
c48c337
Begin rework dom to implement new background behaviour.
AndrienkoAleksandr Jan 17, 2018
12af146
mend
AndrienkoAleksandr Jan 18, 2018
16d7427
Merge remote-tracking branch 'upstream/master' into CHE-7139
AndrienkoAleksandr Jan 18, 2018
b2b0777
Merge remote-tracking branch 'upstream/master' into CHE-7139
AndrienkoAleksandr Jan 22, 2018
f582daf
Fix scroll Side effects and style typo.
AndrienkoAleksandr Jan 24, 2018
d916f6b
Merge remote-tracking branch 'upstream/master' into CHE-7139
AndrienkoAleksandr Jan 24, 2018
e9841f9
Clean up
AndrienkoAleksandr Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ide/che-core-ide-ui/src/main/java/org/eclipse/che/ide/ui/smartTree/Tree.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1319,6 +1319,13 @@ private boolean fireCancellableEvent(GwtEvent<?> event) {
private void ensureTreeElement() {
DivElement element = Document.get().createDivElement();
element.addClassName(treeStyles.styles().tree());

rootContainer = Document.get().createDivElement();
rootContainer.addClassName(treeStyles.styles().contentTree());
rootContainer.setId("content-Tree");

element.appendChild(rootContainer);

setElement(element);
}

Expand Down Expand Up @@ -1381,7 +1388,7 @@ private int[] getVisibleRows(List<Node> visible, int count) {
}

private Element getRootContainer() {
return getElement();
return rootContainer;
}

private void onAdd(StoreAddEvent event) {
Expand Down
2 changes: 2 additions & 0 deletions ide/che-core-ide-ui/src/main/java/org/eclipse/che/ide/ui/smartTree/TreeStyles.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ interface CSS extends CssResource {

String tree();

String contentTree();

String loading();
}

Expand Down
12 changes: 9 additions & 3 deletions ide/che-core-ide-ui/src/main/resources/org/eclipse/che/ide/ui/smartTree/TreeStyles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,14 +120,20 @@
}

.tree {
display: inline-block;
min-width: 100%;
display: relative;
font-size: 0.85em;
outline: none;
overflow-y: auto;
overflow: auto;
padding-bottom: 2px;
}

.contentTree {
min-width: 100%;
position: absolute;
overflow: hidden;
left: 0;
}

.tree:focus {
outline: none;
}
Expand Down