Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selenium: fix expected values list in NavigateToFileTest test #8949

Merged
merged 3 commits into from
Feb 28, 2018

Conversation

SkorikSergey
Copy link
Contributor

What does this PR do?

This PR fixes expected values list in NavigateToFileTest selenium test.

@SkorikSergey SkorikSergey added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/che-qe labels Feb 28, 2018
@@ -159,7 +159,7 @@ public void selectFileByName(String nameOfFile) {
.until(
visibilityOfElementLocated(
By.xpath(format(Locators.FILE_NAME_LIST_SELECT, nameOfFile))));

webElement.click();
WaitUtils.sleepQuietly(500, MILLISECONDS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to consider replacing WaitUtils.sleepQuietly on TestWebElementRenderChecker.waitElementIsRendered.

@SkorikSergey SkorikSergey merged commit d1d8e9e into master Feb 28, 2018
@SkorikSergey SkorikSergey deleted the fixNavigateToFileTest branch February 28, 2018 09:25
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 28, 2018
@benoitf benoitf added this to the 6.2.0 milestone Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants