Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selenium: Remove catching issue #7551 in the selenium tests #9407

Merged
merged 1 commit into from Apr 13, 2018
Merged

Selenium: Remove catching issue #7551 in the selenium tests #9407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 1 addition & 8 deletions ...ium-test/src/test/java/org/eclipse/che/selenium/editor/CheckRestoringSplitEditorTest.java
View file
Open in desktop
Expand Up @@ -14,7 +14,6 @@
import static org.eclipse.che.selenium.core.project.ProjectTemplates.MAVEN_JAVA_MULTIMODULE;
import static org.eclipse.che.selenium.pageobject.CodenvyEditor.TabActionLocator.SPIT_HORISONTALLY;
import static org.eclipse.che.selenium.pageobject.CodenvyEditor.TabActionLocator.SPLIT_VERTICALLY;
import static org.testng.Assert.fail;

import com.google.common.base.Joiner;
import com.google.inject.Inject;
Expand All @@ -38,7 +37,6 @@
import org.eclipse.che.selenium.pageobject.NotificationsPopupPanel;
import org.eclipse.che.selenium.pageobject.PopupDialogsBrowser;
import org.eclipse.che.selenium.pageobject.ProjectExplorer;
import org.openqa.selenium.TimeoutException;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

Expand Down Expand Up @@ -99,12 +97,7 @@ public void checkRestoringStateSplittedEditor() throws IOException, Exception {

seleniumWebDriver.navigate().refresh();
projectExplorer.waitItem(PROJECT_NAME);
try {
projectExplorer.waitVisibilityByName(javaClassName);
} catch (TimeoutException ex) {
// remove try-catch block after issue has been resolved
fail("Known issue https://github.com/eclipse/che/issues/7551", ex);
}
projectExplorer.waitVisibilityByName(javaClassName);

notificationsPopupPanel.waitPopupPanelsAreClosed();
checkSplitdEditorAfterRefreshing(
Expand Down
17 changes: 2 additions & 15 deletions ...src/test/java/org/eclipse/che/selenium/miscellaneous/ConvertToProjectWithPomFileTest.java
View file
Open in desktop
Expand Up @@ -15,7 +15,6 @@
import static org.eclipse.che.selenium.core.constant.TestProjectExplorerContextMenuConstants.SubMenuNew.XML_FILE;
import static org.eclipse.che.selenium.core.project.ProjectTemplates.MAVEN_SPRING;
import static org.eclipse.che.selenium.pageobject.ProjectExplorer.FolderTypes.SIMPLE_FOLDER;
import static org.testng.Assert.fail;

import com.google.inject.Inject;
import java.net.URL;
Expand All @@ -36,7 +35,6 @@
import org.eclipse.che.selenium.pageobject.Menu;
import org.eclipse.che.selenium.pageobject.ProjectExplorer;
import org.eclipse.che.selenium.pageobject.Wizard;
import org.openqa.selenium.TimeoutException;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.BeforeMethod;
import org.testng.annotations.Test;
Expand Down Expand Up @@ -125,13 +123,7 @@ public void checkConvertToProjectWithPomFile() throws Exception {
editor.closeAllTabs();
seleniumWebDriver.navigate().refresh();
projectExplorer.waitProjectExplorer();

try {
projectExplorer.waitDefinedTypeOfFolder(PATH_TO_POM_FILE, SIMPLE_FOLDER);
} catch (TimeoutException ex) {
// Remove try-catch block after issue has been resolved
fail("Known issue https://github.com/eclipse/che/issues/7551");
}
projectExplorer.waitDefinedTypeOfFolder(PATH_TO_POM_FILE, SIMPLE_FOLDER);
}

@Test
Expand All @@ -148,12 +140,7 @@ public void checkEditorTabNameAfterChangingArtifactID() {

seleniumWebDriver.navigate().refresh();
ide.waitOpenedWorkspaceIsReadyToUse();
try {
projectExplorer.waitItem(PROJECT_NAME + "/pom.xml");
} catch (TimeoutException ex) {
// Remove try-catch block after issue has been resolved
fail("Known issue https://github.com/eclipse/che/issues/7551");
}
projectExplorer.waitItem(PROJECT_NAME + "/pom.xml");
editor.waitTabIsPresent("new-qa-spring-sample");

editor.closeAllTabsByContextMenu();
Expand Down
17 changes: 2 additions & 15 deletions ...-test/src/test/java/org/eclipse/che/selenium/workspaces/ProjectStateAfterRefreshTest.java
View file
Open in desktop
Expand Up @@ -11,7 +11,6 @@
package org.eclipse.che.selenium.workspaces;

import static org.eclipse.che.selenium.core.project.ProjectTemplates.MAVEN_SPRING;
import static org.testng.Assert.fail;

import com.google.inject.Inject;
import java.net.URL;
Expand All @@ -24,7 +23,6 @@
import org.eclipse.che.selenium.pageobject.Consoles;
import org.eclipse.che.selenium.pageobject.Ide;
import org.eclipse.che.selenium.pageobject.ProjectExplorer;
import org.openqa.selenium.TimeoutException;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

Expand Down Expand Up @@ -62,12 +60,7 @@ public void checkRestoreStateOfProjectAfterRefreshTest() {
ide.waitOpenedWorkspaceIsReadyToUse();
projectExplorer.waitItem(PROJECT_NAME);

try {
checkFilesAreOpened();
} catch (TimeoutException ex) {
// Remove try-catch block after issue has been resolved
fail("Known issue https://github.com/eclipse/che/issues/7551");
}
checkFilesAreOpened();

editor.closeAllTabsByContextMenu();
}
Expand All @@ -88,13 +81,7 @@ public void checkRestoreStateOfProjectIfPomXmlFileOpened() {
seleniumWebDriver.navigate().refresh();
ide.waitOpenedWorkspaceIsReadyToUse();
projectExplorer.waitItem(PROJECT_NAME);

try {
editor.waitTabIsPresent("qa-spring-sample");
} catch (TimeoutException ex) {
// Remove try-catch block after issue has been resolved
fail("Known issue https://github.com/eclipse/che/issues/7551");
}
editor.waitTabIsPresent("qa-spring-sample");
projectExplorer.waitItem(PROJECT_NAME + "/pom.xml");
projectExplorer.waitItem(PROJECT_NAME + "/src/main/webapp/WEB-INF");
projectExplorer.waitItem(PROJECT_NAME + "/src/main/webapp/WEB-INF/jsp");
Expand Down
11 changes: 1 addition & 10 deletions ...c/test/java/org/eclipse/che/selenium/workspaces/ProjectStateAfterRenameWorkspaceTest.java
View file
Open in desktop
Expand Up @@ -11,7 +11,6 @@
package org.eclipse.che.selenium.workspaces;

import static org.eclipse.che.selenium.core.project.ProjectTemplates.MAVEN_SPRING;
import static org.testng.Assert.fail;

import com.google.inject.Inject;
import java.net.URL;
Expand All @@ -28,7 +27,6 @@
import org.eclipse.che.selenium.pageobject.dashboard.workspaces.WorkspaceDetails;
import org.eclipse.che.selenium.pageobject.dashboard.workspaces.WorkspaceOverview;
import org.eclipse.che.selenium.pageobject.dashboard.workspaces.Workspaces;
import org.openqa.selenium.TimeoutException;
import org.testng.annotations.AfterClass;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;
Expand Down Expand Up @@ -98,14 +96,7 @@ public void checkProjectAfterRenameWs() throws Exception {

ide.waitOpenedWorkspaceIsReadyToUse();
projectExplorer.waitItem(PROJECT_NAME);

try {
projectExplorer.waitItem(PROJECT_NAME + "/src/main/webapp/index.jsp");
} catch (TimeoutException ex) {
// Remove try-catch block after issue has been resolved
fail("Known issue https://github.com/eclipse/che/issues/7551");
}

projectExplorer.waitItem(PROJECT_NAME + "/src/main/webapp/index.jsp");
projectExplorer.waitItem(
PROJECT_NAME + "/src/main/java/org/eclipse/qa/examples/AppController.java");
editor.waitTabIsPresent("index.jsp");
Expand Down
11 changes: 2 additions & 9 deletions .../test/java/org/eclipse/che/selenium/workspaces/ProjectStateAfterWorkspaceRestartTest.java
View file
Open in desktop
Expand Up @@ -13,7 +13,6 @@
import static org.eclipse.che.selenium.core.constant.TestMenuCommandsConstants.Workspace.STOP_WORKSPACE;
import static org.eclipse.che.selenium.core.constant.TestMenuCommandsConstants.Workspace.WORKSPACE;
import static org.eclipse.che.selenium.core.project.ProjectTemplates.MAVEN_SPRING;
import static org.testng.Assert.fail;

import com.google.inject.Inject;
import java.net.URL;
Expand All @@ -27,7 +26,6 @@
import org.eclipse.che.selenium.pageobject.Menu;
import org.eclipse.che.selenium.pageobject.ProjectExplorer;
import org.eclipse.che.selenium.pageobject.ToastLoader;
import org.openqa.selenium.TimeoutException;
import org.testng.annotations.BeforeClass;
import org.testng.annotations.Test;

Expand Down Expand Up @@ -76,13 +74,8 @@ public void checkProjectAfterStopStartWs() {
toastLoader.clickOnToastLoaderButton("Start");
ide.waitOpenedWorkspaceIsReadyToUse();

try {
// check state of the project
checkFilesAreOpened();
} catch (TimeoutException ex) {
// Remove try-catch block after issue has been resolved
fail("Known issue https://github.com/eclipse/che/issues/7551");
}
// check state of the project
checkFilesAreOpened();

projectExplorer.openItemByPath(PROJECT_NAME + "/README.md");
editor.waitActive();
Expand Down