Release 0.10.0 #31
Merged
Release 0.10.0 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
June 17, 2020 11:43
- it's written in markdown, why not carry the extension Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
- added credential check for `utils.buildSession()` and converted it to async - converted from `null` to default `*` in `utils.endevorQualifierToElement()` - moved EndevorNodes.ts to CLI api calls. Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
- remove some TODOs by fixing some typings - remove unneeded function `buildRequestBody()` by using the `setup()` functions provided with each API Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
- it's written in markdown, why not carry the extension Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
- added credential check for `utils.buildSession()` and converted it to async - converted from `null` to default `*` in `utils.endevorQualifierToElement()` - moved EndevorNodes.ts to CLI api calls. Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
- remove some TODOs by fixing some typings - remove unneeded function `buildRequestBody()` by using the `setup()` functions provided with each API Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
- can create profiles - Repos are under profiles in tree - add remove profiles from tree - pwd not required (taken from profiles) Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
- fixed issues with protocol
- not passed downstream at profile creation and also upstream when profile was used to create connection session
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Daniel Statham <Daniel.Statham@Broadcom.com>
zeibura
requested changes
Jun 23, 2020
There was a problem hiding this comment.
I've made a few changes, mostly stylistic, more suggestions are inline. Dan, I think the URL you couldn't work out was just an example host:port as opposed to an instruction to connect to a broadcom server at a specific port, so I've changed that step accordingly, feel free to check with devs if this is correct or not
zeibura
requested changes
Jun 23, 2020
|
Also, just an FYI that the gifs will need updating as they still show the old interface with "new connection" |
Signed-off-by: Daniel Statham <Daniel.Statham@Broadcom.com>
zdmullen
suggested changes
Jun 24, 2020
Agreed. Ideally can either make some using a provided Video showing the "best practice" usage". |
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Signed-off-by: Daniel Statham <Daniel.Statham@Broadcom.com>
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
zdmullen
approved these changes
Jun 25, 2020
Move 2 Endevor Cli API
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
Add integration with Endevor profiles from Zowe CLI
…rsion Update changelog and version
Signed-off-by: Alexandru-Paul Dumitru <alexandru.dumitru@broadcom.com>
remove outstanding gifs
zdmullen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Statham Daniel.Statham@Broadcom.com