-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Implementation for the new mapping #1895
Conversation
aef2711
to
f1f77bc
Compare
30a7d0e
to
c167eac
Compare
I download the artefacts (vsix-cobol-language-support-darwin-x64.zip, vsix-idms-dialect.zip, vsix-daco-dialect.zip) and tested on internal repo. It fails on every DaCo program. Will DM you on slack. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since these changes affect the core functionality and some tests were disabled, please run the internal test suite and do a manual smoke test on the internal repo before proceeding.
Thanks, I have added a use case test for it. Should be covered by unit tests now |
ba4fa99
to
9e92eb3
Compare
Now both IDMS and DaCo code gets properly analysed. But now I am getting a random dance of errors showing up and disappearing when enter code. Maybe worth running the typing test? |
Looks like it is something broken in the processing itself, i will check it in dev |
I have checked it. It is completely the same functionality as we have on development. Looks like when we have errors we have faster processing then expected and that's why we can see these errors. And we have the same in the development branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This refactoring will fix the following issue: #1854
Pay attention to the
org.eclipse.lsp.cobol.common.mapping
package.It contains a new implementation for the mapping. Other changes are just changes due to interface changes.
Also there are some changes with tests. Some tests were updated due to better mapping and a few tests were disabled because of limitations in the use cases test suit.
server/engine/src/test/java/org/eclipse/lsp/cobol/usecases