Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix keyword completion for dialects #1898

Merged

Conversation

ap891843
Copy link
Contributor

@ap891843 ap891843 commented May 25, 2023

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
    - Install IDMS extension.
    - Provide IDMS as a dialect for a workspace in settings.json.
    - Trigger suggestion on a COBOL file (ctrl + space).
    - Verify that IDMS-STATISTICS is present in the list.

Checklist:

  • Each my commit contains one meaningful change
  • I have performed rebase my branch on top of development
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@ap891843 ap891843 requested review from ishche and Nurkambay May 25, 2023 14:32
@ap891843 ap891843 marked this pull request as ready for review May 25, 2023 14:33
Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ap891843 ap891843 force-pushed the bugfix/keywordCompletionDialect branch from edd6e75 to 5669239 Compare May 25, 2023 14:45
Add tests to satisfy the threshold limit for the project. These test are not related to the keyword completion. But are added just to increase the test coverage ,to satisfy the threshold limit set for the project.

Signed-off-by: Aman Prashant <aman.prashant@broadcom.com>
@ishche ishche merged commit 394a40f into eclipse-che4z:development May 26, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants