Introduce Code Action to Resolve Copybooks GH-197 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temanbrcom
added
new feature
temanbrcom
requested review from
ishche,
sergiuilie,
zacanbrcom and
abdrabrcom
|
I faced the Lombok issue again, trying to fix it |
|
the build is failing, please check the output and fix the problem |
temanbrcom
force-pushed
the
code-actions
branch
from
a8f14b8
to
53db3fd
Compare
|
This fail is related to projectlombok/lombok#2044 |
ishche
reviewed
Feb 17, 2020
...p-core-cobol-parser/src/test/java/com/ca/lsp/core/cobol/visitor/LevenshteinDistanceTest.java
Show resolved
Hide resolved
zacanbrcom
reviewed
Feb 17, 2020
...ol/lsp-core-cobol-parser/src/main/java/com/ca/lsp/core/cobol/engine/CobolLanguageEngine.java
Show resolved
Hide resolved
zacanbrcom
reviewed
Feb 17, 2020
com.ca.lsp.cobol/lsp-core-cobol-parser/src/main/java/com/ca/lsp/core/cobol/model/ErrorCode.java
Outdated
Show resolved
Hide resolved
zacanbrcom
reviewed
Feb 17, 2020
...a.lsp.cobol/lsp-core-cobol-parser/src/main/java/com/ca/lsp/core/cobol/model/SyntaxError.java
Outdated
Show resolved
Hide resolved
temanbrcom
force-pushed
the
code-actions
branch
from
53db3fd
to
fbd6a46
Compare
Add logic to the text document service to collect a list of applicable code actions. Add logic to the workspace service to resolve missing copybooks on the Quick Fix. Add error code to determine the code action command type. Register those capabilities on the server initialization.
temanbrcom
force-pushed
the
code-actions
branch
from
fbd6a46
to
453da42
Compare
zacanbrcom
reviewed
Feb 17, 2020
...lsp.cobol/lsp-service-cobol/src/test/java/com/ca/lsp/cobol/service/WorkspaceServiceTest.java
Show resolved
Hide resolved
|
@temanbrcom did u try the behavior also in Che/Theia right? |
|
@ishche I see something strange with npm on the build. Could you, please, have a look at it? |
It looks like registry.npmjs.org problem: |
|
Tested in Che - works fine |
zacanbrcom
approved these changes
Feb 17, 2020
|
🎉 This PR is included in version 0.11.1-alpha.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add logic to the text document service to collect a list of applicable code actions.
Add logic to the workspace service to resolve missing copybooks on the Quick Fix.
Add error code to determine the code action command type.
Register those capabilities on the server initialization.
Clean-up MyLanguageServerImpl to set only supported capabilities #23