Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allowances and status check fields for branch protection rules #5

Closed
eclipse-csi-bot opened this issue Feb 20, 2023 · 10 comments

Comments

@eclipse-csi-bot
Copy link
Contributor

In GitLab by @netomi on Feb 20, 2023, 09:46

There are various fields of a branch protection rule that are not yet supported:

  • bypassForcePushAllowances
  • bypassPullRequestAllowances
  • pushAllowances
  • reviewDismissalAllowances
  • requiredStatusChecks (simple case)

They need paging support to retrieves all items if more than 100 exist. Furthermore, they might contain items of 3 different types: app / team / user which needs to be handled differently. Also there is a mismatch between retrieve / storage and update. The update only works with nodeIds while in the definition file we want more human-readable names, like the slug oder login, so we need to resolve the human-readable name to its ids during an update.

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Mar 29, 2023, 16:37

mentioned in commit cc23cd3

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Mar 29, 2023, 16:59

Added support for pushRestrictions and removed restrictsPushes as it is implicit based on the content of pushRestrictions (when no pushRestrictions its false, true otherwise)

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Mar 30, 2023, 09:22

mentioned in commit 21020e8

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Mar 30, 2023, 09:25

Added support for reviewDismissalAllowances.

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Mar 30, 2023, 10:29

mentioned in commit 0e5e39a

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Mar 30, 2023, 10:53

mentioned in commit b88952b

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Mar 30, 2023, 10:56

Added support for bypassForcePushAllowances and bypassPullRequestAllowances.

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Apr 26, 2023, 09:53

mentioned in commit 8f24234

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Apr 26, 2023, 10:10

mentioned in commit 3f5a90b

@eclipse-csi-bot
Copy link
Contributor Author

In GitLab by @netomi on Apr 26, 2023, 10:16

Added requiredStatusChecks as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant