Skip to content

Commit

Permalink
Fix clang12 warnings on destructor naming
Browse files Browse the repository at this point in the history
../src/ddscxx/include/dds/core/detail/TEntityImpl.hpp:29:29: warning: ISO C++ requires the name after '::~' to be found in the same scope as the name before '::~' [-Wdtor-name]
dds::core::TEntity<DELEGATE>::~TEntity()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~

Signed-off-by: Erik Boasson <eb@ilities.com>
  • Loading branch information
eboasson committed May 11, 2021
1 parent d308369 commit 39ffc05
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion src/ddscxx/include/dds/core/detail/ReferenceImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ dds::core::Reference<DELEGATE>::Reference(const DELEGATE_REF_T& p) : impl_(p)
}

template <typename DELEGATE>
dds::core::Reference<DELEGATE>::~Reference()
dds::core::Reference<DELEGATE>::~Reference<DELEGATE>()
{
}

Expand Down
2 changes: 1 addition & 1 deletion src/ddscxx/include/dds/core/detail/TEntityImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
// Implementation

template <typename DELEGATE>
dds::core::TEntity<DELEGATE>::~TEntity()
dds::core::TEntity<DELEGATE>::~TEntity<DELEGATE>()
{
}

Expand Down
4 changes: 2 additions & 2 deletions src/ddscxx/include/dds/pub/detail/DataWriterImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ DataWriter<T, DELEGATE>::DataWriter(const dds::pub::Publisher& pub,
}

template <typename T, template <typename Q> class DELEGATE>
DataWriter<T, DELEGATE>::~DataWriter()
DataWriter<T, DELEGATE>::~DataWriter<T, DELEGATE>()
{
}

Expand Down Expand Up @@ -405,7 +405,7 @@ dds::pub::detail::DataWriter<T>::DataWriter(
}

template <typename T>
dds::pub::detail::DataWriter<T>::~DataWriter()
dds::pub::detail::DataWriter<T>::~DataWriter<T>()
{
if (!this->closed) {
try {
Expand Down
4 changes: 2 additions & 2 deletions src/ddscxx/include/dds/sub/detail/TDataReaderImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ DataReader<T, DELEGATE>::DataReader(
#endif /* OMG_DDS_MULTI_TOPIC_SUPPORT */

template <typename T, template <typename Q> class DELEGATE>
DataReader<T, DELEGATE>::~DataReader() { }
DataReader<T, DELEGATE>::~DataReader<T, DELEGATE>() { }

template <typename T, template <typename Q> class DELEGATE>
dds::sub::status::DataState
Expand Down Expand Up @@ -514,7 +514,7 @@ dds::sub::detail::DataReader<T>::common_constructor(
}

template <typename T>
dds::sub::detail::DataReader<T>::~DataReader()
dds::sub::detail::DataReader<T>::~DataReader<T>()
{
if (!this->closed) {
try {
Expand Down
2 changes: 1 addition & 1 deletion src/ddscxx/include/dds/topic/detail/TTopicImpl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ dds::topic::detail::Topic<T>::Topic(const dds::domain::DomainParticipant& dp,


template <typename T>
dds::topic::detail::Topic<T>::~Topic()
dds::topic::detail::Topic<T>::~Topic<T>()
{
if (!closed) {
try {
Expand Down

0 comments on commit 39ffc05

Please sign in to comment.