Fixed missing callbacks for pending events #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e-hndrks
force-pushed
the
master_erik
branch
2 times, most recently
from
fded6fb
to
3416c75
Compare
e-hndrks
force-pushed
the
master_erik
branch
2 times, most recently
from
b399b91
to
796d9e2
Compare
|
I started a CI run for this PR after merging eclipse-cyclonedds/cyclonedds#1717 and it looks like you missed something in Iceoryx-specific code: https://dev.azure.com/eclipse-cyclonedds/cyclonedds-cxx/_build/results?buildId=4762&view=logs&j=e4f8c82b-de6b-5575-3950-14744af47318&t=aacbc600-1f24-51b1-8fd9-0679ad3e2601 Perhaps you could have another look? |
When creating an Entity with a Listener, any instantaneous events that occurred during creation would miss their callback. This was caused by the C++ API not being able to wrap the underlying C API with a C++ object prior to C already trying to invoking the callback. That is now resolved by not setting the Listener at creation time, but by setting it after successfully putting a C++ wrapper around the underlying C Entity. This should fix issue eclipse-cyclonedds#410 A prerequisite for applying this fix is to make sure pull request #eclipse-cyclonedds/cyclonedds#1717 is applied to the cyclonedds repository. Signed-off-by: Erik Hendriks <erik.hendriks@zettascale.tech>
|
Indeed, I didn't realize that the C++ repository had specialized Shared Memory tests, and therefore didn't run an IceOryx build. However, those remaining issues should now also have been fixed. |
eboasson
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating an Entity with a Listener, any instantaneous events that occurred during creation would miss their callback.
This was caused by the C++ API not being able to wrap the underlying C API with a C++ object prior to C already trying to invoking the callback.
That is now resolved by not setting the Listener at creation time, but by setting it after successfully putting a C++ wrapper around the underlying C Entity.
This should fix issue #410
A prerequisite for applying this fix is to make sure pull request #eclipse-cyclonedds/cyclonedds#1717 is applied to the cyclonedds repository.