Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes for CI, sync with C #86

Merged

Conversation

thijsmie
Copy link
Contributor

This has become a little bit of a hodgepodge of changes, but at least they are still grouped by commit!

  • Commit 015deb8 syncs the TRY_CONSTRUCT flags with C PR Fixes for XTypes interoperability聽cyclonedds#1242
  • Commit 2191b9e fixes a leak in the python sertype where a ddsi_sertype does not get unref'ed when a topic creation fails.
  • Commit 672f459 fixes a small mistake in TypeObjects of unions with an Enum as discriminator
  • Commit 43e9b2c fixes a mistake that only occurs on windows where the C api can return NULL from an entity name while claiming it is present. This is dealing with the symptom though, I am not exactly sure why it occurs (it doesn't reproduce locally for me, only on CI...)

This should make the CI fully green again, provided the fuzzer doesn't find anything random 馃槃

cyclonedds/idl/_xt_builder.py Show resolved Hide resolved
@thijsmie thijsmie merged commit 2a314d0 into eclipse-cyclonedds:master May 10, 2022
@thijsmie
Copy link
Contributor Author

@eboasson the CI on master had a failure in the fuzzer due to a case in a union being called get which name-clashed with a IdlUnion method, an interesting case indeed 馃槄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants